Skip to content

Commit c257df8

Browse files
committed
Avoid conflicting symbols with V8
V8 uses absl and so does dawn.node. But they use different options apparently.
1 parent 2a80e69 commit c257df8

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

build/build.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ async function createProject() {
5555
'-DDAWN_BUILD_NODE_BINDINGS=1',
5656
'-DDAWN_USE_X11=OFF',
5757
`-DCMAKE_BUILD_TYPE=${kConfig}`,
58+
'-DCMAKE_CXX_VISIBILITY_PRESET=hidden',
59+
'-DCMAKE_VISIBILITY_INLINES_HIDDEN=1',
5860
...addElemIf(isMac, '-DCMAKE_OSX_ARCHITECTURES="x86_64;arm64"'),
5961
...addElemIf(isWin, '-DCMAKE_SYSTEM_VERSION=10.0.26100.0'),
6062
...addElemIf(isMac, '-DCMAKE_OSX_SYSROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk'),

0 commit comments

Comments
 (0)