diff --git a/.claude/skills/devicon-icon-review/SKILL.md b/.claude/skills/devicon-icon-review/SKILL.md new file mode 100644 index 000000000..37084fc87 --- /dev/null +++ b/.claude/skills/devicon-icon-review/SKILL.md @@ -0,0 +1,75 @@ +--- +name: devicon-icon-review +description: Review devicon "new icon" / "update icon" pull requests (and icon proposals or icon files before a PR) the way devicon's maintainers do — whether the technology is accepted, whether the logo is official and current, version naming and aliases, SVG standards (128×128 viewBox, no padding, centred, optimized single-line files), font-readiness of plain/line versions (one path, one colour, no strokes, white cut out), devicon.json correctness, the peek-bot font previews, and PR scope/title. Use this whenever the user asks to review, check, approve, or give feedback on a devicon icon PR or icon SVGs, mentions a PR number in devicons/devicon with an icon title, or asks whether an icon "is ready" — even if they only paste a PR link. +--- + +# Reviewing devicon icon PRs + +The goal is the review a careful devicon maintainer would write: correct, specific, kind, and actionable — every problem comes with the fix (often a ready-to-commit suggestion). Contributors are frequently first-timers; maintainers here link the wiki, explain *why*, and offer help. + +Standards live in `references/devicon-standards.md` (with links to the maintainer comments they come from). Read it before your first review in a session; it's the source of truth for the checklist below. + +## Tools + +- `scripts/check_icon.js --repo ` — checks the icon's `devicon.json` entry and its files: required keys, versions vs files, font versions (one path, one fill, fill = `color`, no white/groups/gradients/strokes), aliases, viewBox/width/height/xmlns, raster ``, ``, ` + + + + + + diff --git a/.claude/skills/svg-icons/evals/plain-from-multicolour-logo/graders/01-viewbox-no-size.md b/.claude/skills/svg-icons/evals/plain-from-multicolour-logo/graders/01-viewbox-no-size.md new file mode 100644 index 000000000..99b830b4b --- /dev/null +++ b/.claude/skills/svg-icons/evals/plain-from-multicolour-logo/graders/01-viewbox-no-size.md @@ -0,0 +1,7 @@ +--- +type: llm +focus: trace +weight: 1 +--- + +acme-original.svg and acme-plain.svg both have viewBox exactly "0 0 128 128" and no width/height attributes on the root diff --git a/.claude/skills/svg-icons/evals/plain-from-multicolour-logo/graders/02-plain-one-path.md b/.claude/skills/svg-icons/evals/plain-from-multicolour-logo/graders/02-plain-one-path.md new file mode 100644 index 000000000..e6893ab00 --- /dev/null +++ b/.claude/skills/svg-icons/evals/plain-from-multicolour-logo/graders/02-plain-one-path.md @@ -0,0 +1,7 @@ +--- +type: llm +focus: trace +weight: 1 +--- + +acme-plain.svg contains exactly one and no other shapes, groups, strokes,