Remove coveralls and add tests

Author: devmotion

JuliaFormatter.toml .JuliaFormatter.tomlJuliaFormatter.toml renamed to .JuliaFormatter.toml

@@ -38,6 +38,3 @@ jobs:
       - uses: codecov/codecov-action@v3
         with:
           files: lcov.info
-      - uses: julia-actions/julia-uploadcoveralls@v1
-        env:
-          COVERALLS_TOKEN: ${{ secrets.COVERALLS_TOKEN }}

.github/workflows/CI.yml

@@ -2,7 +2,6 @@
 
 [![Build Status](https://github.com/devmotion/SimpleUnPack.jl/actions/workflows/CI.yml/badge.svg?branch=main)](https://github.com/devmotion/SimpleUnPack.jl/actions/workflows/CI.yml?query=branch%3Amain)
 [![Coverage](https://codecov.io/gh/devmotion/SimpleUnPack.jl/branch/main/graph/badge.svg)](https://codecov.io/gh/devmotion/SimpleUnPack.jl)
-[![Coverage](https://coveralls.io/repos/github/devmotion/SimpleUnPack.jl/badge.svg?branch=main)](https://coveralls.io/github/devmotion/SimpleUnPack.jl?branch=main)
 [![Code Style: Blue](https://img.shields.io/badge/code%20style-blue-4495d1.svg)](https://github.com/invenia/BlueStyle)
 
 This package provides the `@unpack` macro for destructuring properties.

README.md

@@ -3,45 +3,62 @@ module SimpleUnPack
 export @unpack
 
 """
-    @unpack a, b, ... = rhs
+    @unpack a, b, ... = x
 
-Destructure properties `a`, `b`, ... of `rhs` into variables of the same name.
+Destructure properties `a`, `b`, ... of `x` into variables of the same name.
 
-The behaviour of the macro is equivalent to `(; a, b, ...) = rhs` which was introduced in [Julia#39285](https://github.com/JuliaLang/julia/pull/39285) and is available in Julia >= 1.7.0-DEV.364.
+The behaviour of the macro is equivalent to `(; a, b, ...) = x` which was introduced in [Julia#39285](https://github.com/JuliaLang/julia/pull/39285) and is available in Julia >= 1.7.0-DEV.364.
 """
-macro unpack(args::Expr)
+macro unpack(args)
     return unpack(args)
 end
 
-function unpack(args::Expr)
+function unpack(args)
     # Extract properties and RHS
     if !Meta.isexpr(args, :(=), 2)
-        throw(ArgumentError("`@unpack` can only be applied to expressions of the form `a, b = c`"))
+        throw(
+            ArgumentError(
+                "`@unpack` can only be applied to expressions of the form `a, b, ... = x`"
+            ),
+        )
     end
     lhs, rhs = args.args
     properties = if lhs isa Symbol
         [lhs]
-    elseif Meta.isexpr(lhs, :tuple) && !isempty(lhs.args) && all(x -> x isa Symbol, lhs.args)
+    elseif Meta.isexpr(lhs, :tuple) &&
+        !isempty(lhs.args) &&
+        all(x -> x isa Symbol, lhs.args)
         lhs.args
     else
-        throw(ArgumentError("`@unpack` can only be applied to expressions of the form `a, b = c`"))
+        throw(
+            ArgumentError(
+                "`@unpack` can only be applied to expressions of the form `a, b, ... = x`",
+            ),
+        )
     end
 
     if VERSION >= v"1.7.0-DEV.364"
         # Fall back to destructuring in Base when available:
         # https://github.com/JuliaLang/julia/pull/39285
-        return Expr(:(=), Expr(:tuple, Expr(:parameters, (esc(p) for p in properties)...)), esc(rhs))
+        return Expr(
+            :(=), Expr(:tuple, Expr(:parameters, (esc(p) for p in properties)...)), esc(rhs)
+        )
     else
         @gensym object
         block = Expr(:block)
         for p in properties
-            push!(block.args, Expr(:(=), esc(p), Expr(:call, :getproperty, esc(object), QuoteNode(p))))
+            push!(
+                block.args,
+                Expr(:(=), esc(p), Expr(:call, :getproperty, esc(object), QuoteNode(p))),
+            )
         end
-        return quote
-            $(esc(object)) = $(esc(rhs)) # In case the RHS is an expression
-            $block
-            $(esc(object)) # Return evaluation of rhs to ensure the behaviour is the same as (; ...) = rhs
-        end |> Base.remove_linenums!
+        return Base.remove_linenums!(
+            quote
+                $(esc(object)) = $(esc(rhs)) # In case the RHS is an expression
+                $block
+                $(esc(object)) # Return evaluation of rhs to ensure the behaviour is the same as (; ...) = rhs
+            end,
+        )
     end
 end
 

src/SimpleUnPack.jl

@@ -61,4 +61,12 @@ end
         @test @inferred(f(Struct(42, 1.0, "z"))) == (42, 1.0)
         @test @inferred(f(Property(42))) == (42, 1.0)
     end
-end
+
+    @testset "Errors" begin
+        d = (; x=42, y=1.0)
+        @test_throws ArgumentError @macroexpand @unpack d
+        @test_throws ArgumentError @macroexpand @unpack (; x=42, y=1.0)
+        @test_throws ArgumentError @macroexpand @unpack x, y, (; x=42, y=1.0)
+        @test_throws ArgumentError @macroexpand @unpack x, 1 = (; x=42, y=1.0)
+    end
+end