diff --git a/.claude/skills/running-tend/SKILL.md b/.claude/skills/running-tend/SKILL.md index c65325c7b..c2e56ab14 100644 --- a/.claude/skills/running-tend/SKILL.md +++ b/.claude/skills/running-tend/SKILL.md @@ -26,3 +26,9 @@ Proposed as an overlay note and rejected in [#421](https://github.com/diffplug/d Before a `review-runs`/`review-reviewers` sweep flags a tend behavior as waste or files it upstream, check this list — these were already raised and ruled on, so re-filing burns a session and spams upstream: - **`tend-review` silently running a full review on the bot's own PRs is intended, not waste.** The diff read *is* the review — it catches lint failures and edge cases even though self-approval is impossible, so a silent exit means the review ran and found nothing to post. Ruled intended behavior by the upstream owner in [max-sixty/tend#607](https://github.com/max-sixty/tend/issues/607) (closed as intended, same ruling as tend#212/#154). Do not treat self-review-of-bot-PRs no-ops as cost waste and do not re-file. (The companion `tend-mention` no-op on undirected bot comments, [tend#606](https://github.com/max-sixty/tend/issues/606), was *fixed* upstream — that one is resolved, not rejected.) + +## The tend workflow-regen PR stays non-draft + +`tend-nightly` opens the `chore: update tend workflows (X → Y)` PR non-draft; leave it that way. `AGENTS.md`'s draft rule exists to control Chromatic spend, and Chromatic's `pull_request` paths (`lib/**`, `docs/stories/**`) never match a workflows-only diff, so neither `UI Tests` nor `Storybook Publish` runs on it either way. Converting it costs something real: the maintainer's later ready-flip routes through the verdict-drop path in [#665](https://github.com/diffplug/dormouse/issues/665). + +Don't re-derive this from the earlier workflow-regen PRs. `isDraft` reads `false` on every merged PR whatever it was opened as, so `gh pr list --state all --json isDraft` cannot answer how one was opened — only `issues//timeline`'s `convert_to_draft` and `ready_for_review` events can.