Claude Code review R1: fix post-install markers blocking update check, remove unused plugin-process dep, fix spec inconsistencies

Author: nedtwigg

docs/specs/auto-update.md

@@ -193,12 +193,11 @@ The `check()` call handles endpoint fetching, version comparison, and signature
 |------|----------------|
 | `standalone/src/updater.ts` | Update check, background download, quit-time install, post-install markers, state |
 | `standalone/src/UpdateBanner.tsx` | Banner React component |
-| `standalone/src/App.tsx` | Mounts `<UpdateBanner />` at the top of the app |
+| `standalone/src/main.tsx` | Mounts `<UpdateBanner />` at the top of the app |
 
 The updater module is standalone-only — it does not go into `lib/` because the VSCode extension and website have no use for it.
 
 ## Setup required
 
-1. `pnpm --filter mouseterm-standalone add @tauri-apps/plugin-updater @tauri-apps/plugin-process`
-2. Add `"process"` to the `plugins` allowlist in `tauri.conf.json` if not already present.
-3. Add `"installMode": "passive"` to the updater Windows config in `tauri.conf.json`.
+1. `pnpm --filter mouseterm-standalone add @tauri-apps/plugin-updater`
+2. Add `"installMode": "passive"` to the updater Windows config in `tauri.conf.json`.

pnpm-lock.yaml

@@ -13,7 +13,6 @@
   "dependencies": {
     "@phosphor-icons/react": "^2.1.10",
     "@tauri-apps/api": "^2.0.0",
-    "@tauri-apps/plugin-process": "^2.3.1",
     "@tauri-apps/plugin-shell": "^2.0.0",
     "@tauri-apps/plugin-updater": "^2.10.1",
     "@xterm/addon-fit": "^0.11.0",

standalone/package.json

@@ -80,13 +80,14 @@ describe('updater', () => {
       expect(localStorage.getItem(STORAGE_KEY)).toBeNull();
     });
 
-    it('skips update check when a post-install marker is present', async () => {
+    it('still runs update check after reading a post-install marker', async () => {
       localStorage.setItem(STORAGE_KEY, JSON.stringify({ from: '0.3.0', to: '0.4.0' }));
 
       startUpdateCheck();
-      await vi.advanceTimersByTimeAsync(10_000);
+      await vi.advanceTimersByTimeAsync(5_000);
+      await vi.advanceTimersByTimeAsync(0);
 
-      expect(mocks.check).not.toHaveBeenCalled();
+      expect(mocks.check).toHaveBeenCalledOnce();
     });
   });
 

standalone/src/updater.test.ts

@@ -68,17 +68,13 @@ async function runUpdateCheck(): Promise<void> {
       const marker = JSON.parse(raw);
       if (marker.failed) {
         setState({ status: 'post-update-failure', version: marker.version });
-        registerCloseHandler();
-        return;
       } else if (marker.from && marker.to) {
         setState({ status: 'post-update-success', from: marker.from, to: marker.to });
         setTimeout(() => {
           if (state.status === 'post-update-success') {
             setState({ status: 'idle' });
           }
         }, 10_000);
-        registerCloseHandler();
-        return;
       }
     }
   } catch {