Fix review comments for PR microsoft#631

- Add 'p' to checkDefaultValue for bare -p flag support
- Fix error message to show both '0' and '1' as valid values
- Remove trailing space in colon-separated format output
- Add test cases for -p and -p 1 flags

Author: dlevy-msft-sql

cmd/sqlcmd/sqlcmd.go

@@ -332,6 +332,7 @@ func checkDefaultValue(args []string, i int) (val string) {
 		'k': "0",
 		'L': "|", // | is the sentinel for no value since users are unlikely to use it. It's "reserved" in most shells
 		'X': "0",
+		'p': "0",
 	}
 	if isFlag(args[i]) && len(args[i]) == 2 && (len(args) == i+1 || args[i+1][0] == '-') {
 		if v, ok := flags[rune(args[i][1])]; ok {
@@ -552,7 +553,7 @@ func normalizeFlags(cmd *cobra.Command) error {
 			case "0", "1":
 				return pflag.NormalizedName(name)
 			default:
-				err = invalidParameterError("-p", v, "1")
+				err = invalidParameterError("-p", v, "0", "1")
 				return pflag.NormalizedName("")
 			}
 		}

cmd/sqlcmd/sqlcmd_test.go

@@ -99,6 +99,12 @@ func TestValidCommandLineToArgsConversion(t *testing.T) {
 		{[]string{"-k", "-X", "-r", "-z", "something"}, func(args SQLCmdArguments) bool {
 			return args.warnOnBlockedCmd() && !args.useEnvVars() && args.getControlCharacterBehavior() == sqlcmd.ControlRemove && *args.ErrorsToStderr == 0 && args.ChangePassword == "something"
 		}},
+		{[]string{"-p"}, func(args SQLCmdArguments) bool {
+			return args.PrintStatistics != nil && *args.PrintStatistics == 0
+		}},
+		{[]string{"-p", "1"}, func(args SQLCmdArguments) bool {
+			return args.PrintStatistics != nil && *args.PrintStatistics == 1
+		}},
 		{[]string{"-N"}, func(args SQLCmdArguments) bool {
 			return args.EncryptConnection == "true"
 		}},

pkg/sqlcmd/sqlcmd.go

@@ -612,7 +612,7 @@ func (s *Sqlcmd) printStatistics(elapsedMs int64, numBatches int) {
 	if *s.PrintStatistics == 1 {
 		// Colon-separated format: n:x:t1:t2:t3
 		// packetSize:numBatches:totalTime:avgTime:batchesPerSec
-		fmt.Fprintf(out, "\n%d:%d:%d:%.2f:%.2f \n", packetSize, numBatches, elapsedMs, avgTime, batchesPerSec)
+		fmt.Fprintf(out, "\n%d:%d:%d:%.2f:%.2f\n", packetSize, numBatches, elapsedMs, avgTime, batchesPerSec)
 	} else {
 		// Standard format
 		fmt.Fprintf(out, "\nNetwork packet size (bytes): %d\n", packetSize)