Allow -r without argument, defaulting to 0

ODBC sqlcmd allows -r without an explicit value, defaulting to 0
(enable stderr redirection for severity >= 11). Previously go-sqlcmd
required -r0 or -r1 explicitly.

Changes:
- normalizeFlags: Accept empty value for -r flag
- getOptionalIntArgument: Return 0 for empty value instead of -1
- Add TestErrorsToStderrDefaultValue test

Author: dlevy-msft-sql

cmd/sqlcmd/sqlcmd.go

@@ -376,6 +376,11 @@ func getOptionalIntArgument(cmd *cobra.Command, name string) (i *int) {
 	if val != nil && val.Changed {
 		i = new(int)
 		value := val.Value.String()
+		// Handle empty value for flags that allow no argument (e.g., -r without value defaults to 0)
+		if value == "" {
+			*i = 0
+			return
+		}
 		v, e := strconv.Atoi(value)
 		if e != nil {
 			*i = -1
@@ -513,7 +518,7 @@ func normalizeFlags(cmd *cobra.Command) error {
 			}
 		case errorsToStderr:
 			switch v {
-			case "0", "1":
+			case "0", "1", "":
 				return pflag.NormalizedName(name)
 			default:
 				err = invalidParameterError("-r", v, "0", "1")

cmd/sqlcmd/sqlcmd_test.go

@@ -246,6 +246,49 @@ func TestValidateFlags(t *testing.T) {
 	}
 }
 
+func TestErrorsToStderrDefaultValue(t *testing.T) {
+	// Test that -r without a value defaults to 0 (ODBC sqlcmd compatibility)
+	arguments := &SQLCmdArguments{}
+	cmd := &cobra.Command{
+		Use: "testCommand",
+		PreRunE: func(cmd *cobra.Command, argss []string) error {
+			SetScreenWidthFlags(arguments, cmd)
+			return nil
+		},
+		Run: func(cmd *cobra.Command, argss []string) {
+		},
+		SilenceErrors: true,
+		SilenceUsage:  true,
+	}
+	setFlags(cmd, arguments)
+	// Test -r0 explicit
+	cmd.SetArgs([]string{"-r0"})
+	err := cmd.Execute()
+	assert.NoError(t, err, "-r0 should not error")
+	assert.NotNil(t, arguments.ErrorsToStderr, "ErrorsToStderr should be set")
+	assert.Equal(t, 0, *arguments.ErrorsToStderr, "-r0 should set value to 0")
+
+	// Test -r1 explicit
+	arguments = &SQLCmdArguments{}
+	cmd2 := &cobra.Command{
+		Use: "testCommand",
+		PreRunE: func(cmd *cobra.Command, argss []string) error {
+			SetScreenWidthFlags(arguments, cmd)
+			return nil
+		},
+		Run: func(cmd *cobra.Command, argss []string) {
+		},
+		SilenceErrors: true,
+		SilenceUsage:  true,
+	}
+	setFlags(cmd2, arguments)
+	cmd2.SetArgs([]string{"-r1"})
+	err = cmd2.Execute()
+	assert.NoError(t, err, "-r1 should not error")
+	assert.NotNil(t, arguments.ErrorsToStderr, "ErrorsToStderr should be set")
+	assert.Equal(t, 1, *arguments.ErrorsToStderr, "-r1 should set value to 1")
+}
+
 // Simulate main() using files
 func TestRunInputFiles(t *testing.T) {
 	o, err := os.CreateTemp("", "sqlcmdmain")