Merge pull request #353 from dnephin/add_flake8

Add flake8

Author: bfirsh

.travis.yml

@@ -16,6 +16,7 @@ before_script:
  - 'if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then orchard hosts create $TRAVIS_JOB_ID; fi'
 script:
  - nosetests tests/unit
+ - flake8 fig
  - 'if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then script/travis-integration; fi'
 after_script:
  - 'if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then orchard hosts rm -f $TRAVIS_JOB_ID; fi'

fig/__init__.py

@@ -1,4 +1,4 @@
 from __future__ import unicode_literals
-from .service import Service
+from .service import Service  # noqa:flake8
 
 __version__ = '0.5.2'

fig/cli/command.py

@@ -8,7 +8,6 @@
 import re
 import yaml
 from ..packages import six
-import sys
 
 from ..project import Project
 from ..service import ConfigError
@@ -19,6 +18,7 @@
 
 log = logging.getLogger(__name__)
 
+
 class Command(DocoptCommand):
     base_dir = '.'
 

fig/cli/main.py

@@ -281,13 +281,13 @@ def scale(self, options):
             try:
                 num = int(num)
             except ValueError:
-                raise UserError('Number of containers for service "%s" is not a number' % service)
+                raise UserError('Number of containers for service "%s" is not a '
+                                'number' % service_name)
             try:
                 self.project.get_service(service_name).scale(num)
             except CannotBeScaledError:
                 raise UserError('Service "%s" cannot be scaled because it specifies a port on the host. If multiple containers for this service were created, the port would clash.\n\nRemove the ":" from the port definition in fig.yml so Docker can choose a random port for each container.' % service_name)
 
-
     def start(self, options):
         """
         Start existing containers.
@@ -357,5 +357,6 @@ def handler(signal, frame):
                 print("Gracefully stopping... (press Ctrl+C again to force)")
                 self.project.stop(service_names=service_names)
 
+
 def list_containers(containers):
     return ", ".join(c.name for c in containers)

fig/cli/utils.py

@@ -65,11 +65,11 @@ def prettydate(d):
     elif s < 120:
         return '1 minute ago'
     elif s < 3600:
-        return '{0} minutes ago'.format(s/60)
+        return '{0} minutes ago'.format(s / 60)
     elif s < 7200:
         return '1 hour ago'
     else:
-        return '{0} hours ago'.format(s/3600)
+        return '{0} hours ago'.format(s / 3600)
 
 
 def mkdir(path, permissions=0o700):
@@ -103,8 +103,8 @@ def split_buffer(reader, separator):
             index = buffered.find(separator)
             if index == -1:
                 break
-            yield buffered[:index+1]
-            buffered = buffered[index+1:]
+            yield buffered[:index + 1]
+            buffered = buffered[index + 1:]
 
     if len(buffered) > 0:
         yield buffered

fig/container.py

@@ -1,6 +1,7 @@
 from __future__ import unicode_literals
 from __future__ import absolute_import
 
+
 class Container(object):
     """
     Represents a Docker container, constructed from the output of

fig/project.py

@@ -38,6 +38,7 @@ def visit(n):
 
     return sorted_services
 
+
 class Project(object):
     """
     A collection of services.
@@ -216,6 +217,6 @@ def __init__(self, msg):
     def __str__(self):
         return self.msg
 
+
 class DependencyError(ConfigurationError):
     pass
-

fig/service.py

@@ -132,7 +132,6 @@ def scale(self, desired_num):
 
         self.remove_stopped()
 
-
     def remove_stopped(self, **options):
         for c in self.containers(stopped=True):
             if not c.is_running:
@@ -212,7 +211,7 @@ def start_container_if_stopped(self, container, **options):
             log.info("Starting %s..." % container.name)
             return self.start_container(container, **options)
 
-    def start_container(self, container=None, intermediate_container=None,**override_options):
+    def start_container(self, container=None, intermediate_container=None, **override_options):
         if container is None:
             container = self.create_container(**override_options)
 
@@ -342,7 +341,7 @@ def _get_container_create_options(self, override_options, one_off=False):
         if 'environment' in container_options:
             if isinstance(container_options['environment'], list):
                 container_options['environment'] = dict(split_env(e) for e in container_options['environment'])
-            container_options['environment'] = dict(resolve_env(k,v) for k,v in container_options['environment'].iteritems())
+            container_options['environment'] = dict(resolve_env(k, v) for k, v in container_options['environment'].iteritems())
 
         if self.can_be_built():
             if len(self.client.images(name=self._build_tag_name())) == 0:
@@ -459,13 +458,15 @@ def split_port(port):
             external_port = (external_ip,)
     return internal_port, external_port
 
+
 def split_env(env):
     if '=' in env:
         return env.split('=', 1)
     else:
         return env, None
 
-def resolve_env(key,val):
+
+def resolve_env(key, val):
     if val is not None:
         return key, val
     elif key in os.environ:

requirements-dev.txt

@@ -2,3 +2,4 @@ mock==1.0.1
 nose==1.3.0
 pyinstaller==2.1
 unittest2
+flake8

tox.ini

@@ -7,3 +7,9 @@ deps =
     -rrequirements-dev.txt
 commands =
     nosetests {posargs}
+    flake8 fig
+
+[flake8]
+# ignore line-length for now
+ignore = E501,E203
+exclude = fig/packages/