Use conventional naming for consts

Author: atifaziz

src/DocoptNet/Internals/Option.cs

@@ -34,7 +34,7 @@ public override string ToString()
             return $"Option({ShortName},{LongName},{ArgCount},{Value})";
         }
 
-        const string DESC_SEPARATOR = "  ";
+        const string DescSeparator = "  ";
 
         static readonly char[] OptionDelimiters = { ' ', '\t', ',', '=' };
 
@@ -46,7 +46,7 @@ public static Option Parse(string optionDescription)
             string longName = null;
             var argCount = 0;
             var value = ArgValue.False;
-            var (options, _, description) = optionDescription.Trim().Partition(DESC_SEPARATOR);
+            var (options, _, description) = optionDescription.Trim().Partition(DescSeparator);
             foreach (var s in options.Split(OptionDelimiters, StringSplitOptions.RemoveEmptyEntries))
             {
                 if (s.StartsWith("--"))

tests/DocoptNet.Tests/Assumptions.cs

@@ -12,10 +12,10 @@ public class Assumptions
         [Test]
         public void String_Split_with_no_args_should_split_on_white_space()
         {
-            const string TEST_STRING = "first second\tthird\nfourth \n\t\ffifth";
-            var s1 = TEST_STRING.Split();
+            const string testString = "first second\tthird\nfourth \n\t\ffifth";
+            var s1 = testString.Split();
             Assert.AreEqual(8, s1.Length);
-            var s2 = TEST_STRING.Split(Array.Empty<char>(), StringSplitOptions.RemoveEmptyEntries);
+            var s2 = testString.Split(Array.Empty<char>(), StringSplitOptions.RemoveEmptyEntries);
             Assert.AreEqual(5, s2.Length);
         }
     }

tests/DocoptNet.Tests/DocoptTests.cs

@@ -84,7 +84,7 @@ public void Match_opt_and_arg()
             Assert.AreEqual(expected, actual);
         }
 
-        const string DOC = @"Usage: prog [-vqr] [FILE]
+        const string Doc = @"Usage: prog [-vqr] [FILE]
               prog INPUT OUTPUT
               prog --help
 
@@ -108,7 +108,7 @@ public void Match_one_opt_with_arg()
                     {"INPUT", default},
                     {"OUTPUT", default}
                 };
-            var actual = new Docopt().Apply(DOC, "-v file.py");
+            var actual = new Docopt().Apply(Doc, "-v file.py");
             Assert.AreEqual(expected, actual);
         }
 
@@ -125,20 +125,20 @@ public void Match_one_opt_only()
                     {"INPUT", default},
                     {"OUTPUT", default}
                 };
-            var actual = new Docopt().Apply(DOC, "-v");
+            var actual = new Docopt().Apply(Doc, "-v");
             Assert.AreEqual(expected, actual);
         }
 
         [Test]
         public void No_match()
         {
-            Assert.Throws<DocoptInputErrorException>(() => new Docopt().Apply(DOC, "-v input.py output.py"));
+            Assert.Throws<DocoptInputErrorException>(() => new Docopt().Apply(Doc, "-v input.py output.py"));
         }
 
         [Test]
         public void Non_existent_long()
         {
-            Assert.Throws<DocoptInputErrorException>(() => new Docopt().Apply(DOC, "--fake"));
+            Assert.Throws<DocoptInputErrorException>(() => new Docopt().Apply(Doc, "--fake"));
         }
 
         [Test]
@@ -152,7 +152,7 @@ public void Should_exit_error_code_1()
                     message = e.Message;
                     errorCode = e.ErrorCode;
                 };
-            d.Apply(DOC, "--fake", exit:true);
+            d.Apply(Doc, "--fake", exit:true);
             StringAssert.StartsWith("Usage", message);
             Assert.AreEqual(1, errorCode, "Should exit with error code 1 when exit=true and invalid args provided");
         }
@@ -168,7 +168,7 @@ public void Display_help()
                 message = e.Message;
                 errorCode = e.ErrorCode;
             };
-            d.Apply(DOC, "--help");
+            d.Apply(Doc, "--help");
             StringAssert.StartsWith("Usage", message);
             Assert.AreEqual(0, errorCode);
         }

tests/DocoptNet.Tests/ParseDefaultsTests.cs

@@ -8,7 +8,7 @@ public class ParseDefaultsTests
         [Test]
         public void Test_parse_defaults()
         {
-            const string DOC = @"usage: prog
+            const string doc = @"usage: prog
                 Options:
                 -h, --help  Print help message.
                 -o FILE     Output file.
@@ -17,7 +17,7 @@ public void Test_parse_defaults()
 
             var expected = new Option[]
                 {new Option("-h", "--help"), new Option("-o", null, 1), new Option(null, "--verbose")};
-            Assert.AreEqual(expected, Docopt.ParseDefaults(DOC));
+            Assert.AreEqual(expected, Docopt.ParseDefaults(doc));
         }
 
         [Test]

tests/DocoptNet.Tests/UsageTests.cs

@@ -9,19 +9,19 @@ public class UsageTests
         [Test]
         public void Test_formal_usage()
         {
-            const string DOC =
+            const string doc =
 "Usage: prog [-hv] ARG\r\n" +
 "       prog N M\r\n" +
 "\r\n" +
 "       prog is a program.";
-            var usage = Docopt.ParseSection("usage:", DOC).First();
+            var usage = Docopt.ParseSection("usage:", doc).First();
             Assert.AreEqual("Usage: prog [-hv] ARG\r\n       prog N M", usage);
             Assert.AreEqual("( [-hv] ARG ) | ( N M )", Docopt.FormalUsage(usage));
         }
         [Test]
         public void Should_parse_usage_section_correctly()
         {
-            const string USAGE = @"usage: this
+            const string usage = @"usage: this
 
 usage:hai
 usage: this that
@@ -60,7 +60,7 @@ public void Should_parse_usage_section_correctly()
                     "usage:\r\n\ttoo\r\n\ttar",
                     "Usage: eggs spam",
                     "usage: pit stop"
-                }, Docopt.ParseSection("usage:", USAGE), "Variations on casing, spaces and tabs");
+                }, Docopt.ParseSection("usage:", usage), "Variations on casing, spaces and tabs");
         }
     }
 }