Skip to content

Commit 94099bb

Browse files
authored
ci: install bash5 on macOS via Brew w/ no auto-update (#63)
- per the deleted in-line comments, the reason it was installed as a static binary was because Brew's auto-update is slow - we can disable the auto-update though, so do that instead in order to install via Brew
1 parent d3a457a commit 94099bb

2 files changed

Lines changed: 1 addition & 13 deletions

File tree

-476 KB
Binary file not shown.

travis/get_bash5_macos.sh

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@
44
#
55
# Our hack for macos bash version too old for unit testing
66

7-
# brew update takes very long time
8-
# homebrew is already updated, but it's still really slow
9-
#- if [[ "$RUNNER_OS" == "macOS" ]]; then brew update ; fi
10-
#- if [[ "$RUNNER_OS" == "macOS" ]]; then brew install bash; fi
11-
127
pathshow ()
138
{
149
local var=${1:-PATH};
@@ -17,14 +12,7 @@ pathshow ()
1712

1813
if [[ "$RUNNER_OS" == "macOS" ]]; then
1914
if ((BASH_VERSINFO[0] <= 3)) ; then
20-
21-
# The following hack kept a bash5 binary in our repository
22-
# only for our speedup pupose.
23-
24-
# we simply install it
25-
bash_bin=/usr/local/bin/bash
26-
gzip -dc ./bash-5.0.16_x86_64-apple-darwin17.7.0.gz | \
27-
sudo bash -c "cat > $bash_bin && chmod a+x $bash_bin"
15+
HOMEBREW_NO_AUTO_UPDATE=1 brew install bash # quick install, no brew update (c.f. https://apple.stackexchange.com/a/293252/167983)
2816
fi
2917
fi
3018

0 commit comments

Comments
 (0)