Commit 98de506
Add TTY detection for interactive prompts to prevent agent hangs (#1547)
* Initial plan
* Add TTY detection for interactive prompts to prevent agent hangs
- CertCommand: detect non-interactive stdin before prompting, fail with
clear error directing users to --force flag
- ProxyEngine: skip first-run cert trust prompt in non-interactive mode,
default to trusting the certificate
- Update --force option help text to note it's required for non-interactive use
Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
* Address review feedback: add CI env var check and return non-zero exit code
- CertCommand and ProxyEngine: check both Console.IsInputRedirected and
CI env var for non-interactive detection, matching ExecuteAsync pattern
- RemoveCert returns int: exit code 1 for non-interactive failure or
exceptions, 0 for success
Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: waldekmastykarz <11164679+waldekmastykarz@users.noreply.github.com>
Co-authored-by: Waldek Mastykarz <waldek@mastykarz.nl>
Co-authored-by: Garry Trinder <garry@trinder365.co.uk>1 parent 9635ab1 commit 98de506
2 files changed
Lines changed: 26 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
86 | 93 | | |
87 | 94 | | |
88 | 95 | | |
89 | | - | |
| 96 | + | |
90 | 97 | | |
91 | 98 | | |
92 | 99 | | |
| |||
111 | 118 | | |
112 | 119 | | |
113 | 120 | | |
| 121 | + | |
114 | 122 | | |
115 | 123 | | |
116 | 124 | | |
117 | 125 | | |
| 126 | + | |
118 | 127 | | |
119 | 128 | | |
120 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
234 | | - | |
235 | | - | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
236 | 248 | | |
237 | 249 | | |
238 | 250 | | |
| |||
0 commit comments