Skip to content

Commit 364d6d5

Browse files
committed
Preserve the current values when loading debug options in JobManager
Do not set them to false if they are not explicitly set in the configuration, leave them as they are. This avoids the duplicated logic of declaring them as "false" when they are declared and also when they are loaded.
1 parent 8e410ef commit 364d6d5

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

  • runtime/bundles/org.eclipse.core.jobs/src/org/eclipse/core/internal/jobs

runtime/bundles/org.eclipse.core.jobs/src/org/eclipse/core/internal/jobs/JobManager.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1366,14 +1366,14 @@ private long lifeTimeInMs() {
13661366
@Override
13671367
public void optionsChanged(DebugOptions options) {
13681368
DEBUG_TRACE = options.newDebugTrace(PI_JOBS);
1369-
DEBUG = options.getBooleanOption(OPTION_DEBUG_JOBS, false);
1370-
DEBUG_BEGIN_END = options.getBooleanOption(OPTION_DEBUG_BEGIN_END, false);
1371-
DEBUG_YIELDING = options.getBooleanOption(OPTION_DEBUG_YIELDING, false);
1372-
DEBUG_YIELDING_DETAILED = options.getBooleanOption(OPTION_DEBUG_YIELDING_DETAILED, false);
1373-
DEBUG_DEADLOCK = options.getBooleanOption(OPTION_DEADLOCK_ERROR, false);
1374-
DEBUG_LOCKS = options.getBooleanOption(OPTION_LOCKS, false);
1375-
DEBUG_SHUTDOWN = options.getBooleanOption(OPTION_SHUTDOWN, false);
1376-
DEBUG_BLOCKED_UNBLOCKED = options.getBooleanOption(OPTION_DEBUG_BLOCKED_UNBLOCKED, false);
1369+
DEBUG = options.getBooleanOption(OPTION_DEBUG_JOBS, DEBUG);
1370+
DEBUG_BEGIN_END = options.getBooleanOption(OPTION_DEBUG_BEGIN_END, DEBUG_BEGIN_END);
1371+
DEBUG_YIELDING = options.getBooleanOption(OPTION_DEBUG_YIELDING, DEBUG_YIELDING);
1372+
DEBUG_YIELDING_DETAILED = options.getBooleanOption(OPTION_DEBUG_YIELDING_DETAILED, DEBUG_YIELDING_DETAILED);
1373+
DEBUG_DEADLOCK = options.getBooleanOption(OPTION_DEADLOCK_ERROR, DEBUG_DEADLOCK);
1374+
DEBUG_LOCKS = options.getBooleanOption(OPTION_LOCKS, DEBUG_LOCKS);
1375+
DEBUG_SHUTDOWN = options.getBooleanOption(OPTION_SHUTDOWN, DEBUG_SHUTDOWN);
1376+
DEBUG_BLOCKED_UNBLOCKED = options.getBooleanOption(OPTION_DEBUG_BLOCKED_UNBLOCKED, DEBUG_BLOCKED_UNBLOCKED);
13771377
}
13781378

13791379
@Override

0 commit comments

Comments
 (0)