diff --git a/lib/rules/avoid-leaking-state-in-ember-objects.js b/lib/rules/avoid-leaking-state-in-ember-objects.js index 3069286991..471f45000a 100644 --- a/lib/rules/avoid-leaking-state-in-ember-objects.js +++ b/lib/rules/avoid-leaking-state-in-ember-objects.js @@ -37,7 +37,9 @@ function isAllowed(value) { ember.isFunctionExpression(value) || types.isLiteral(value) || types.isIdentifier(value) || - types.isCallExpression(value) || + // NOTE: CallExpression intentionally removed — myProp: A() or + // myProp: EmberObject.create() creates a shared instance across all + // object instances, leaking state. See issue #300. types.isBinaryExpression(value) || types.isTemplateLiteral(value) || types.isTaggedTemplateExpression(value) ||