Skip to content

Commit 10aa861

Browse files
committed
Fix $id error on map embed
Fixes #353
1 parent 68406cd commit 10aa861

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 4.0.3 - 2022-07-11
2+
### Fixed
3+
- Fixed $id embed issue (Fixes #353)
4+
15
## 4.0.2 - 2022-06-08
26
### Fixed
37
- Misc fixes via @davidwebca & @jamesedmonston

src/models/EmbedOptions.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ class EmbedOptions extends StaticOptions
2222
// Properties
2323
// =========================================================================
2424

25-
/** @var string The ID of the map (unique ID will be generated if null) */
26-
public string $id;
25+
/** @var string|null The ID of the map (unique ID will be generated if null) */
26+
public ?string $id = null;
2727

2828
/** @var array Options to be passed to the JS map */
2929
public array $options = [];

src/web/assets/MapAsset.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public function init ()
3030
VueAsset::class,
3131
];
3232

33-
if (getenv('ETHER_ENVIRONMENT'))
33+
if (getenv('ETHER_ENVIRONMENT') === 'true')
3434
{
3535
$this->js = [
3636
'https://localhost:8080/app.js',

0 commit comments

Comments
 (0)