Merge pull request #14 from exercism/add-comments-string-interpolation

Add comments when approving a two-fer that uses string interpolation

Author: Karlo Soriano

lib/analyzers/two_fer/analyze.rb

@@ -9,6 +9,7 @@ module TwoFer
     missing_default_param:   "ruby.two-fer.missing_default_param",   # "There is no correct default param - the tests will fail"
     incorrect_default_param: "ruby.two-fer.incorrect_default_param", # "You could set the default value to 'you' to avoid conditionals"
     reassigning_param:       "ruby.two-fer.reassigning_param",       # "You don't need to reassign - use the default param"
+    string_interpolation:    "ruby.two-fer.string_interpolation",    # "String interpolation is a good way to build strings, here are some other options to explore"
     string_concatenation:    "ruby.two-fer.string_concatenation",    # "Rather than using string building, use interpolation"
     kernel_format:           "ruby.two-fer.kernel_format",           # "Rather than using the format method, use interpolation"
     string_format:           "ruby.two-fer.string_format",           # "Rather than using string's format/percentage method, use interpolation"
@@ -77,7 +78,7 @@ def check_for_single_line_solution!
 
       if solution.uses_string_interpolation?
         if solution.string_interpolation_is_correct?
-          approve_if_implicit_return!
+          approve_if_implicit_return!(:string_interpolation, {name_variable: solution.first_parameter_name})
         else
           refer_to_mentor!
         end

test/exercises/two_fer_test.rb

@@ -37,7 +37,6 @@ def self.two_fer(name="you")
     }
     results = TwoFer::Analyze.(source)
     assert_equal :approve, results[:status]
-    assert_equal [], results[:comments]
   end
 
   def test_simple_module_passes
@@ -51,7 +50,6 @@ def self.two_fer(name="you")
     }
     results = TwoFer::Analyze.(source)
     assert_equal :approve, results[:status]
-    assert_equal [], results[:comments]
   end
 
   def test_simple_module_with_bookkeeping_passes
@@ -69,7 +67,6 @@ module Bookkeeping
     }
     results = TwoFer::Analyze.(source)
     assert_equal :approve, results[:status]
-    assert_equal [], results[:comments]
   end
 
   def test_different_module_name_fails
@@ -163,6 +160,19 @@ def self.two_fer(name="you")
     assert_equal [{comment: "ruby.two-fer.string_concatenation", params: {name_variable: :name}}], results[:comments]
   end
 
+  def test_string_interpolation_passes
+    source = %q{
+      class TwoFer
+        def self.two_fer(name="you")
+          "One for #{name}, one for me."
+        end
+      end
+    }
+    results = TwoFer::Analyze.(source)
+    assert_equal :approve, results[:status]
+    assert_equal [{comment: "ruby.two-fer.string_interpolation", params: {name_variable: :name}}], results[:comments]
+  end
+
   def test_for_kernel_format
     #skip
     source = %q{