Add matcher for an arbitrary block argument

Author: Karlo Soriano

lib/analyzers/acronym/representation.rb

@@ -30,6 +30,7 @@ def uses_method_chain?
     end
 
     def uses_method_chain_with_block?
+      arg = ArbitraryArg.new
       matchers = [
         {
           method_name: :upcase,
@@ -42,7 +43,7 @@ def uses_method_chain_with_block?
           type: :block,
           method_name: :map,
           chained?: true,
-          arguments: s(:args, s(:arg, :word))
+          arguments: arg,
         },
         {
           method_name: :map,
@@ -59,7 +60,7 @@ def uses_method_chain_with_block?
         },
         {
           method_name: :chr,
-          receiver: s(:lvar, :word)
+          receiver: arg.lvar
         }
       ]
 
@@ -152,3 +153,25 @@ def ==(other)
     other.type == :lvar
   end
 end
+
+class NamedLvar
+  attr_accessor :name
+
+  def ==(other)
+    other == Parser::AST::Node.new(:lvar, name)
+  end
+end
+
+class ArbitraryArg
+  def lvar
+    @lvar ||= NamedLvar.new
+  end
+
+  def ==(other)
+    if other.type == :args
+      lvar.name = other.first.node_parts
+    end
+
+    other.type == :args
+  end
+end

test/exercises/acronym_test.rb

@@ -41,6 +41,19 @@ def self.abbreviate(words)
     assert_equal ["ruby.acronym.block_syntax.shorthand"], results[:comments]
   end
 
+  def test_method_chaining_with_block_syntax_with_arbitrary_arg_passes
+    source = %q{
+      class Acronym
+        def self.abbreviate(words)
+          words.tr('-', ' ').split.map { |term| term.chr }.join.upcase
+        end
+      end
+    }
+    results = Acronym::Analyze.(source)
+    assert_equal :approve, results[:status]
+    assert_equal ["ruby.acronym.block_syntax.shorthand"], results[:comments]
+  end
+
   def test_module_method_passes
     source = %q{
       module Acronym