Andrew hung nguyen (#34)

* hacktoberfest contribution - binary to hexadecimal

* Adding regexp to detect invalid expressions and unit test cases

* Added a function that converts from binary to octal and included unit tests for it

* Refactored the Fibonacci function to use dynamic programming

Author: AndrewHUNGNguyen

easyPythonpi/TestFibRefactored.py

@@ -0,0 +1,46 @@
+import unittest
+import easyPythonpi
+from easyPythonpi import InvalidNumberFibException
+
+class TestFibRefactored(unittest.TestCase):
+
+    def test_fibonacci_0(self):
+        with self.assertRaises(easyPythonpi.InvalidNumberFibException):
+            easyPythonpi.fibonacci(0)  
+
+    def test_fibonacci_negative_number(self):
+        with self.assertRaises(easyPythonpi.InvalidNumberFibException):
+            easyPythonpi.fibonacci(-10)          
+
+    def test_fibonacci_1(self):
+        self.assertEqual( easyPythonpi.fibonacci(1), 0)    
+
+    def test_fibonacci_2(self):
+        self.assertEqual( easyPythonpi.fibonacci(2), 1)      
+
+    def test_fibonacci_3(self):
+        self.assertEqual( easyPythonpi.fibonacci(3), 1)   
+
+    def test_fibonacci_4(self):
+        self.assertEqual( easyPythonpi.fibonacci(4), 2)        
+
+    def test_fibonacci_5(self):
+        self.assertEqual( easyPythonpi.fibonacci(5), 3) 
+
+    def test_fibonacci_6(self):
+        self.assertEqual( easyPythonpi.fibonacci(6), 5) 
+
+    def test_fibonacci_7(self):
+        self.assertEqual( easyPythonpi.fibonacci(7), 8)  
+
+    def test_fibonacci_8(self):
+        self.assertEqual( easyPythonpi.fibonacci(8), 13)                           
+            
+    def test_fibonacci_9(self):
+        self.assertEqual( easyPythonpi.fibonacci(9), 21)  
+
+    def test_fibonacci_10(self):
+        self.assertEqual( easyPythonpi.fibonacci(10), 34)    
+
+if __name__ == '__main__':
+    unittest.main()

easyPythonpi/__pycache__/easyPythonpi.cpython-311.pyc

@@ -41,17 +41,42 @@ def Perimeter_circle(r:'float')->'float': # To find the perimeter of a circle us
     PI = 3.142
     return 2 * PI * r 
 
+
 def fibonacci(n:'int')->'int':  #To find the nth fibonacci series
-    if n<0:
-        print("Incorrect input")
+    """Finds the fibonacci of the nth sequence.
+
+    This function calculates the fibonacci sequence.  This function calculates
+    the nth fibonacci of a number by finding the sum of two numbers in the 
+    fibonacci sequence before n
+
+    Args:
+        n ('int') : The number to find the fibonacci sequence of, assumes n >=1
+                    as valid numbers to find the fibonacci of n.
+
+    Returns:
+        The fibonacci of arg n.
+
+    Raises:
+        No errors 
+    """
+    if n<=0:
+        raise InvalidNumberFibException(n)
     # First Fibonacci number is 0
     elif n==1:
         return 0
     # Second Fibonacci number is 1
     elif n==2:
         return 1
     else:
-        return fibonacci(n-1)+fibonacci(n-2)
+        fib1 = 0
+        fib2 = 1
+
+        for i in range(2,n-1):
+             fibN = fib1 + fib2
+             fib1 = fib2 
+             fib2 = fibN
+
+        return fib1 +fib2
 
 def sort(list:'list'):    # To bubble sort and array or list
     for i in range(len(list) - 1, 0, -1):
@@ -462,3 +487,8 @@ def count_vowels(ip_str:'str')->'int':
 # define exception for invalid Binary Strings
 class InvalidBinaryException(Exception):
     pass
+
+class InvalidNumberFibException(Exception):
+    def __init__(self, n, message="n is not valid, must be greater than or equal to 1"):
+         self.n = n
+         self.message = message