Skip to content

Commit 9089b9e

Browse files
committed
updates
1 parent 19f3286 commit 9089b9e

2 files changed

Lines changed: 4 additions & 11 deletions

File tree

README.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,15 +118,10 @@ The SDK can be initialized by passing [datafile](https://featurevisor.com/docs/b
118118

119119
```java
120120
import com.featurevisor.sdk.Featurevisor;
121-
import com.featurevisor.sdk.ChildInstance;
122-
import com.featurevisor.types.DatafileContent;
123121

124122
// Load datafile content
125123
String datafileUrl = "https://cdn.yoursite.com/datafile.json";
126-
String datafileContent = "..." // ... load your datafile content
127-
128-
// Parse the JSON into DatafileContent object
129-
DatafileContent datafile = DatafileContent.fromJson(datafileContent);
124+
String datafileContent = "..." // load your datafile content
130125

131126
// Create SDK instance
132127
Featurevisor f = Featurevisor.createInstance(

src/main/java/com/featurevisor/sdk/Featurevisor.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public static Featurevisor createInstance() {
4949
return createInstance(new Options());
5050
}
5151

52-
public static Featurevisor createInstance(com.featurevisor.types.DatafileContent datafile) {
52+
public static Featurevisor createInstance(DatafileContent datafile) {
5353
return createInstance(new Options().datafile(datafile));
5454
}
5555

@@ -223,8 +223,7 @@ public Featurevisor(Options options) {
223223
.logger(this.logger));
224224
} else if (options.getDatafileString() != null) {
225225
try {
226-
ObjectMapper mapper = new ObjectMapper();
227-
DatafileContent datafile = mapper.readValue(options.getDatafileString(), DatafileContent.class);
226+
DatafileContent datafile = DatafileContent.fromJson(options.getDatafileString());
228227
this.datafileReader = new DatafileReader(new DatafileReader.DatafileReaderOptions()
229228
.datafile(datafile)
230229
.logger(this.logger));
@@ -269,8 +268,7 @@ public void setDatafile(DatafileContent datafile) {
269268
*/
270269
public void setDatafile(String datafileString) {
271270
try {
272-
ObjectMapper mapper = new ObjectMapper();
273-
DatafileContent datafile = mapper.readValue(datafileString, DatafileContent.class);
271+
DatafileContent datafile = DatafileContent.fromJson(datafileString);
274272
setDatafile(datafile);
275273
} catch (Exception e) {
276274
this.logger.error("could not parse datafile string", Map.of("error", e.getMessage()));

0 commit comments

Comments
 (0)