Merge pull request matplotlib#27290 from ksunden/macos_segfault

tacaswell · web-flow · commit f4ca1ea0e95f · 2023-11-08T19:41:23.000-05:00
Ensure GIL while releasing buffer
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -1132,8 +1132,10 @@ - (void)setCanvas: (PyObject*)newCanvas
 }
 
 static void _buffer_release(void* info, const void* data, size_t size) {
+    PyGILState_STATE gstate = PyGILState_Ensure();
     PyBuffer_Release((Py_buffer *)info);
     free(info);
+    PyGILState_Release(gstate);
 }
 
 static int _copy_agg_buffer(CGContextRef cr, PyObject *renderer)

Original file line number	Diff line number	Diff line change
`@@ -1132,8 +1132,10 @@ - (void)setCanvas: (PyObject*)newCanvas`
`1132`	`1132`	`}`
`1133`	`1133`
`1134`	`1134`	`static void _buffer_release(void* info, const void* data, size_t size) {`
	`1135`	`+ PyGILState_STATE gstate = PyGILState_Ensure();`
`1135`	`1136`	`PyBuffer_Release((Py_buffer *)info);`
`1136`	`1137`	`free(info);`
	`1138`	`+ PyGILState_Release(gstate);`
`1137`	`1139`	`}`
`1138`	`1140`
`1139`	`1141`	`static int _copy_agg_buffer(CGContextRef cr, PyObject *renderer)`