fix(fcm): Improve topic management performance and fix test lint issues

- Hoist URL-encoded topic computation out of the per-token request loops.
- Mount an HTTPAdapter with a connection pool size of 100 on the FCM client session.
- Fix line length and method signature override lint warnings in test_messaging.py.

Author: lahirumaramba

firebase_admin/messaging.py

@@ -512,6 +512,12 @@ def __init__(self, app: App) -> None:
         timeout = app.options.get('httpTimeout', _http_client.DEFAULT_TIMEOUT_SECONDS)
         self._credential = app.credential.get_credential()
         self._client = _http_client.JsonHttpClient(credential=self._credential, timeout=timeout)
+        fcm_adapter = requests.adapters.HTTPAdapter(
+            pool_connections=100,
+            pool_maxsize=100,
+            max_retries=_http_client.DEFAULT_RETRY_CONFIG
+        )
+        self._client.session.mount('https://fcm.googleapis.com', fcm_adapter)
         self._async_client = _http_client.HttpxAsyncClient(
             credential=self._credential, timeout=timeout)
 
@@ -640,10 +646,10 @@ def _make_topic_management_request_v1(
     ) -> TopicManagementResponse:
         """Helper method that sends topic subscription requests via FCM v1 API."""
         tokens_list, topic_name = self._validate_topic_management_args(tokens, topic)
+        encoded_topic = urllib.parse.quote(topic_name, safe='')
 
         def send_request(token: str):
             encoded_token = urllib.parse.quote(token, safe='')
-            encoded_topic = urllib.parse.quote(topic_name, safe='')
             base_url = f'{self._fcm_topic_url}/{encoded_token}/topicSubscriptions'
             if is_subscribe:
                 url = f'{base_url}?topic_name={encoded_topic}'
@@ -682,11 +688,11 @@ async def _make_topic_management_request_v1_async(
     ) -> TopicManagementResponse:
         """Helper method that sends topic subscription requests asynchronously via FCM v1 API."""
         tokens_list, topic_name = self._validate_topic_management_args(tokens, topic)
+        encoded_topic = urllib.parse.quote(topic_name, safe='')
         semaphore = asyncio.Semaphore(100)
 
         async def send_request_async(token: str):
             encoded_token = urllib.parse.quote(token, safe='')
-            encoded_topic = urllib.parse.quote(topic_name, safe='')
             base_url = f'{self._fcm_topic_url}/{encoded_token}/topicSubscriptions'
             if is_subscribe:
                 url = f'{base_url}?topic_name={encoded_topic}'

tests/test_messaging.py

@@ -2688,7 +2688,9 @@ def test_invalid_topic(self, topic):
             messaging.unsubscribe_from_topic('test-token', topic)
         assert str(excinfo.value) == expected
 
-    @pytest.mark.parametrize('topic', ['/topics/', '/foo/bar', 'foo bar', 'f*o*o', '/topics/f+o+o', '$foo', '/topics/foo&'])
+    @pytest.mark.parametrize('topic', [
+        '/topics/', '/foo/bar', 'foo bar', 'f*o*o', '/topics/f+o+o', '$foo', '/topics/foo&'
+    ])
     def test_malformed_topic(self, topic):
         with pytest.raises(ValueError) as excinfo:
             messaging.subscribe_to_topic('test-token', topic)
@@ -2705,7 +2707,10 @@ def test_subscribe_to_topic_single(self):
         assert resp.failure_count == 0
         assert resp.errors == []
         assert len(recorder) == 1
-        expected_url = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/token1/topicSubscriptions?topic_name=test-topic'
+        expected_url = (
+            'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/'
+            'token1/topicSubscriptions?topic_name=test-topic'
+        )
         self._assert_request(recorder[0], 'POST', expected_url, {})
 
     def test_subscribe_to_topic_prefixed(self):
@@ -2715,7 +2720,10 @@ def test_subscribe_to_topic_prefixed(self):
         assert resp.failure_count == 0
         assert resp.errors == []
         assert len(recorder) == 1
-        expected_url = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/token1/topicSubscriptions?topic_name=test-topic'
+        expected_url = (
+            'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/'
+            'token1/topicSubscriptions?topic_name=test-topic'
+        )
         self._assert_request(recorder[0], 'POST', expected_url, {})
 
     def test_unsubscribe_from_topic_single(self):
@@ -2725,7 +2733,10 @@ def test_unsubscribe_from_topic_single(self):
         assert resp.failure_count == 0
         assert resp.errors == []
         assert len(recorder) == 1
-        expected_url = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/token1/topicSubscriptions/test-topic?allow_missing=true'
+        expected_url = (
+            'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/'
+            'token1/topicSubscriptions/test-topic?allow_missing=true'
+        )
         self._assert_request(recorder[0], 'DELETE', expected_url, None)
 
     def test_subscribe_to_topic_already_exists_409(self):
@@ -2753,7 +2764,7 @@ def test_topic_management_multiple_tokens(self):
         recorder = []
 
         class MultiTokenMockAdapter(requests.adapters.HTTPAdapter):
-            def send(self, request, **kwargs):
+            def send(self, request, **kwargs):  # pylint: disable=arguments-differ,unused-argument
                 recorder.append(request)
                 resp = requests.models.Response()
                 resp.url = request.url
@@ -2834,7 +2845,10 @@ def teardown_class(cls):
     @pytest.mark.asyncio
     @respx.mock
     async def test_subscribe_to_topic_async_single(self):
-        url = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/token1/topicSubscriptions?topic_name=test-topic'
+        url = (
+            'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/'
+            'token1/topicSubscriptions?topic_name=test-topic'
+        )
         route = respx.post(url).mock(return_value=respx.MockResponse(200, json={}))
         resp = await messaging.subscribe_to_topic_async('token1', 'test-topic')
         assert route.call_count == 1
@@ -2845,7 +2859,10 @@ async def test_subscribe_to_topic_async_single(self):
     @pytest.mark.asyncio
     @respx.mock
     async def test_subscribe_to_topic_async_already_exists(self):
-        url = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/token1/topicSubscriptions?topic_name=test-topic'
+        url = (
+            'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/'
+            'token1/topicSubscriptions?topic_name=test-topic'
+        )
         payload = {'error': {'status': 'ALREADY_EXISTS', 'message': 'Already exists'}}
         route = respx.post(url).mock(return_value=respx.MockResponse(409, json=payload))
         resp = await messaging.subscribe_to_topic_async('token1', 'test-topic')
@@ -2857,7 +2874,10 @@ async def test_subscribe_to_topic_async_already_exists(self):
     @pytest.mark.asyncio
     @respx.mock
     async def test_unsubscribe_from_topic_async_single(self):
-        url = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/token1/topicSubscriptions/test-topic?allow_missing=true'
+        url = (
+            'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/'
+            'token1/topicSubscriptions/test-topic?allow_missing=true'
+        )
         route = respx.delete(url).mock(return_value=respx.MockResponse(200, json={}))
         resp = await messaging.unsubscribe_from_topic_async('token1', 'test-topic')
         assert route.call_count == 1
@@ -2868,7 +2888,10 @@ async def test_unsubscribe_from_topic_async_single(self):
     @pytest.mark.asyncio
     @respx.mock
     async def test_unsubscribe_from_topic_async_not_found(self):
-        url = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/token1/topicSubscriptions/test-topic?allow_missing=true'
+        url = (
+            'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/'
+            'token1/topicSubscriptions/test-topic?allow_missing=true'
+        )
         payload = {'error': {'status': 'NOT_FOUND', 'message': 'Not found'}}
         route = respx.delete(url).mock(return_value=respx.MockResponse(404, json=payload))
         resp = await messaging.unsubscribe_from_topic_async('token1', 'test-topic')
@@ -2882,14 +2905,17 @@ async def test_unsubscribe_from_topic_async_not_found(self):
     @pytest.mark.asyncio
     @respx.mock
     async def test_subscribe_to_topic_async_multiple(self):
-        url1 = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/token1/topicSubscriptions?topic_name=test-topic'
-        url2 = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/token2/topicSubscriptions?topic_name=test-topic'
-        url3 = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations/token3/topicSubscriptions?topic_name=test-topic'
+        base = 'https://fcm.googleapis.com/v1/projects/explicit-project-id/registrations'
+        url1 = f'{base}/token1/topicSubscriptions?topic_name=test-topic'
+        url2 = f'{base}/token2/topicSubscriptions?topic_name=test-topic'
+        url3 = f'{base}/token3/topicSubscriptions?topic_name=test-topic'
         route1 = respx.post(url1).mock(return_value=respx.MockResponse(200, json={}))
-        route2 = respx.post(url2).mock(return_value=respx.MockResponse(404, json={'error': {'status': 'NOT_FOUND'}}))
+        route2 = respx.post(url2).mock(
+            return_value=respx.MockResponse(404, json={'error': {'status': 'NOT_FOUND'}}))
         route3 = respx.post(url3).mock(return_value=respx.MockResponse(200, json={}))
 
-        resp = await messaging.subscribe_to_topic_async(['token1', 'token2', 'token3'], 'test-topic')
+        resp = await messaging.subscribe_to_topic_async(
+            ['token1', 'token2', 'token3'], 'test-topic')
         assert route1.call_count == 1
         assert route2.call_count == 1
         assert route3.call_count == 1