From f12c5a6d7707ca0ff088de101dfc25b5583a48e3 Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:01 +0100 Subject: [PATCH 01/18] fix(docs): remove nonexistent async utility reference (FB-5346) --- docsrc/firebolt.async_db.rst | 8 -------- 1 file changed, 8 deletions(-) diff --git a/docsrc/firebolt.async_db.rst b/docsrc/firebolt.async_db.rst index 08a504d13b2..adacbe0e613 100644 --- a/docsrc/firebolt.async_db.rst +++ b/docsrc/firebolt.async_db.rst @@ -31,11 +31,3 @@ Cursor :exclude-members: BaseCursor, check_not_closed, check_query_executed, is_db_available, is_engine_running :undoc-members: :show-inheritance: - -Util ------------------------------- - -.. automodule:: firebolt.async_db.util - :members: - :undoc-members: - :show-inheritance: From 297d1732c8974bb98e06264bd64412b64af12eba Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:01 +0100 Subject: [PATCH 02/18] fix(docs): correct database model reference (FB-5346) --- docsrc/firebolt.model.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsrc/firebolt.model.rst b/docsrc/firebolt.model.rst index 671014066df..3f15d447561 100644 --- a/docsrc/firebolt.model.rst +++ b/docsrc/firebolt.model.rst @@ -9,7 +9,7 @@ The model package contains various classes and functions for managing Firebolt e Database ------------------------------ -.. automodule:: firebolt.model.database +.. automodule:: firebolt.model.V2.database :members: :exclude-members: DatabaseKey, FieldMask :undoc-members: From 0f23d3096fe4fc38262e3fd2c35f0e9d2e43666c Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 03/18] fix(docs): correct instance type model reference (FB-5346) --- docsrc/firebolt.model.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsrc/firebolt.model.rst b/docsrc/firebolt.model.rst index 3f15d447561..f7c82d540cb 100644 --- a/docsrc/firebolt.model.rst +++ b/docsrc/firebolt.model.rst @@ -30,7 +30,7 @@ Engine Instance type ------------------------------------ -.. automodule:: firebolt.model.instance_type +.. automodule:: firebolt.model.V2.instance_type :members: :exclude-members: InstanceTypeKey :undoc-members: From 855a8557844837a96431cec3830b353f33c529fa Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 04/18] fix(docs): correct base service reference (FB-5346) --- docsrc/firebolt.service.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsrc/firebolt.service.rst b/docsrc/firebolt.service.rst index add37e88194..ec868a31401 100644 --- a/docsrc/firebolt.service.rst +++ b/docsrc/firebolt.service.rst @@ -4,7 +4,7 @@ Service The service package enables launching and cataloging Firebolt engines and databases. -.. automodule:: firebolt.service.base +.. automodule:: firebolt.service.V2.base :members: :exclude-members: BaseService :undoc-members: From 2aa3fae17ddfddae8e987f7dd1b30140bbd1f5eb Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 05/18] fix(docs): correct database service reference (FB-5346) --- docsrc/firebolt.service.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsrc/firebolt.service.rst b/docsrc/firebolt.service.rst index ec868a31401..8af33642080 100644 --- a/docsrc/firebolt.service.rst +++ b/docsrc/firebolt.service.rst @@ -15,7 +15,7 @@ The service package enables launching and cataloging Firebolt engines and databa Database -------------------------------- -.. automodule:: firebolt.service.database +.. automodule:: firebolt.service.V2.database :members: :undoc-members: :show-inheritance: From 4449dbfe2eda897355724b299d6bb1bedaaa0020 Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 06/18] fix(docs): correct engine service reference (FB-5346) --- docsrc/firebolt.service.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsrc/firebolt.service.rst b/docsrc/firebolt.service.rst index 8af33642080..0c22cc17865 100644 --- a/docsrc/firebolt.service.rst +++ b/docsrc/firebolt.service.rst @@ -25,7 +25,7 @@ Database Engine ------------------------------ -.. automodule:: firebolt.service.engine +.. automodule:: firebolt.service.V2.engine :members: :undoc-members: :show-inheritance: From 8748397b29ba42b3e300eb9910a6dbb37cc46014 Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 07/18] fix(docs): correct instance type service reference (FB-5346) --- docsrc/firebolt.service.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsrc/firebolt.service.rst b/docsrc/firebolt.service.rst index 0c22cc17865..f7745ae1a1c 100644 --- a/docsrc/firebolt.service.rst +++ b/docsrc/firebolt.service.rst @@ -33,7 +33,7 @@ Engine Instance type -------------------------------------- -.. automodule:: firebolt.service.instance_type +.. automodule:: firebolt.service.V2.instance_type :members: :exclude-members: InstanceTypeLookup :undoc-members: From 73e42a0acb05441661af08f36a0ca599aae92e7e Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 08/18] fix(docs): correct types service reference (FB-5346) --- docsrc/firebolt.service.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsrc/firebolt.service.rst b/docsrc/firebolt.service.rst index f7745ae1a1c..fee549d9106 100644 --- a/docsrc/firebolt.service.rst +++ b/docsrc/firebolt.service.rst @@ -50,7 +50,7 @@ Manager Types ----------------------------- -.. automodule:: firebolt.service.types +.. automodule:: firebolt.service.V2.types :members: :undoc-members: :show-inheritance: From 8baa14169be2ef535c3844b333b734281f74607c Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 09/18] fix(docs): document the V2 engine instead of its empty compatibility class (FB-5346) --- docsrc/Managing_resources.rst | 2 +- docsrc/firebolt.model.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docsrc/Managing_resources.rst b/docsrc/Managing_resources.rst index 66d6045e21d..1871a59c4d8 100644 --- a/docsrc/Managing_resources.rst +++ b/docsrc/Managing_resources.rst @@ -285,7 +285,7 @@ Updating an engine Update an engine to change its specifications, returning an updated version of the engine. The engine must be stopped in order to be updated. -For a list of engine parameters that can be updated, see :meth:`~firebolt.model.engine.Engine.update` +For a list of engine parameters that can be updated, see :meth:`~firebolt.model.V2.engine.Engine.update` :: diff --git a/docsrc/firebolt.model.rst b/docsrc/firebolt.model.rst index f7c82d540cb..3f4af167ff2 100644 --- a/docsrc/firebolt.model.rst +++ b/docsrc/firebolt.model.rst @@ -20,7 +20,7 @@ Database Engine ---------------------------- -.. automodule:: firebolt.model.engine +.. automodule:: firebolt.model.V2.engine :members: :exclude-members: EngineKey, FieldMask, check_attached_to_database, wait :undoc-members: From 9faa4404e25565c72382355046f32da60c971256 Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 10/18] fix(docs): align managed connection parameter table borders (FB-5346) --- docsrc/Connecting_and_queries.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsrc/Connecting_and_queries.rst b/docsrc/Connecting_and_queries.rst index 2250bf3e63b..b34fd3e216f 100644 --- a/docsrc/Connecting_and_queries.rst +++ b/docsrc/Connecting_and_queries.rst @@ -45,7 +45,7 @@ To get started, follow the steps below: +------------------------------------+---------------------------------------------------------------------------------------------------------------+ | ``engine_name`` | Optional. The name of the engine to use for SQL queries. | +------------------------------------+---------------------------------------------------------------------------------------------------------------+ - | ``autocommit`` | Optional. Boolean (default: True). When True, each statement is committed immediately. | + | ``autocommit`` | Optional. Boolean (default: True). When True, each statement is committed immediately. | | | When False, statements are executed in transactions that must be explicitly committed. | +------------------------------------+---------------------------------------------------------------------------------------------------------------+ From c1de524aff5af5bd546565a8b57454bd88ddb4be Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 11/18] fix(docs): align Core connection parameter table borders (FB-5346) --- docsrc/Connecting_and_queries.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docsrc/Connecting_and_queries.rst b/docsrc/Connecting_and_queries.rst index b34fd3e216f..684de2da9a6 100644 --- a/docsrc/Connecting_and_queries.rst +++ b/docsrc/Connecting_and_queries.rst @@ -178,12 +178,12 @@ To get started, follow the steps below: A connection requires the following parameters: +------------------------------------+---------------------------------------------------------------------------------------------------------------+ - | ``auth`` | Auth object of type FireboltCore. This is a special authentication type that doesn't require credentials. | + | ``auth`` | Auth object of type FireboltCore. This is a special authentication type that doesn't require credentials. | +------------------------------------+---------------------------------------------------------------------------------------------------------------+ - | ``database`` | Optional. The name of the database you would like to connect to. Defaults to "firebolt" if not specified. | + | ``database`` | Optional. The name of the database you would like to connect to. Defaults to "firebolt" if not specified. | +------------------------------------+---------------------------------------------------------------------------------------------------------------+ - | ``url`` | Optional. The URL of the Firebolt Core instance of form ://:. | - | | Defaults to "http://localhost:3473" if not specified. | + | ``url`` | Optional. The URL of the Firebolt Core instance of form ://:. | + | | Defaults to "http://localhost:3473" if not specified. | +------------------------------------+---------------------------------------------------------------------------------------------------------------+ Here's how to create a connection to Firebolt Core: From 9e22af3f5dc97b241313b07f4d62f9bc3cfd759c Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 12/18] fix(docs): match query result heading underline length (FB-5346) --- docsrc/Connecting_and_queries.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsrc/Connecting_and_queries.rst b/docsrc/Connecting_and_queries.rst index 684de2da9a6..8d683d720b3 100644 --- a/docsrc/Connecting_and_queries.rst +++ b/docsrc/Connecting_and_queries.rst @@ -313,7 +313,7 @@ below use the data queried from ``test_table`` created in the Fetching query result information ------------------------ +--------------------------------- After running a query, you can fetch information about the results using the same ``cursor`` object. The examples below are from the last SELECT query in :ref:`connecting_and_queries:Inserting and selecting data`. From 86d0d9e0c4d623ab56511ed35f746e6e4d0a1eb8 Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 13/18] fix(docs): repair asynchronous streaming literal block (FB-5346) --- docsrc/Connecting_and_queries.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docsrc/Connecting_and_queries.rst b/docsrc/Connecting_and_queries.rst index 8d683d720b3..8aac134f6d5 100644 --- a/docsrc/Connecting_and_queries.rst +++ b/docsrc/Connecting_and_queries.rst @@ -890,6 +890,7 @@ Synchronous example: Asynchronous example: :: + async with async_connection.cursor() as cursor: await cursor.execute_stream("SELECT * FROM my_huge_table") async for row in cursor: From 663a787c590a79881e7600296c3f0aadd504ae8d Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 14/18] fix(docs): give HTTP clients a unique section label (FB-5346) --- docsrc/firebolt.client.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsrc/firebolt.client.rst b/docsrc/firebolt.client.rst index d27ead79456..40f7f139e04 100644 --- a/docsrc/firebolt.client.rst +++ b/docsrc/firebolt.client.rst @@ -12,7 +12,7 @@ Auth :undoc-members: :show-inheritance: -Client +HTTP clients ----------------------------- .. automodule:: firebolt.client.client From 3b962824cbc2f5d866214735da04e485d72de901 Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 15/18] fix(docs): avoid documenting connect twice (FB-5346) --- docsrc/firebolt.db.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docsrc/firebolt.db.rst b/docsrc/firebolt.db.rst index 5bc47346258..2307f5f5a76 100644 --- a/docsrc/firebolt.db.rst +++ b/docsrc/firebolt.db.rst @@ -17,6 +17,7 @@ Connection .. automodule:: firebolt.db.connection :members: + :exclude-members: connect :inherited-members: :undoc-members: :show-inheritance: From cf685a5ef863b01902697eb798c091c9d93bc5e1 Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 16/18] fix(docs): resolve sync and async cursor Connection references (FB-5346) --- docsrc/conf.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/docsrc/conf.py b/docsrc/conf.py index 34c4a894ff9..8f57b4088e1 100644 --- a/docsrc/conf.py +++ b/docsrc/conf.py @@ -65,3 +65,18 @@ # relative to this directory. They are copied after the builtin static files, # so a file named "default.css" will overwrite the builtin "default.css". html_static_path = [] + + +def qualify_cursor_connections(app, doctree): + from sphinx.addnodes import pending_xref + + for node in doctree.findall(pending_xref): + module = node.get("py:module", "") + if node.get("reftarget") == "Connection" and module in ( + "firebolt.db.cursor", "firebolt.async_db.cursor" + ): + node["reftarget"] = module.removesuffix("cursor") + "connection.Connection" + + +def setup(app): + app.connect("doctree-read", qualify_cursor_connections) From 535d6e75bfe80dc98fb2f8bfe01c96885a61088e Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 15:54:02 +0100 Subject: [PATCH 17/18] fix(docs): wrap connection parameter table descriptions (FB-5346) --- docsrc/Connecting_and_queries.rst | 4 ++++ docsrc/_static/custom.css | 13 +++++++++++++ docsrc/conf.py | 3 ++- 3 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 docsrc/_static/custom.css diff --git a/docsrc/Connecting_and_queries.rst b/docsrc/Connecting_and_queries.rst index 8aac134f6d5..18c47696e6d 100644 --- a/docsrc/Connecting_and_queries.rst +++ b/docsrc/Connecting_and_queries.rst @@ -36,6 +36,8 @@ To get started, follow the steps below: A connection requires the following parameters: + .. rst-class:: connection-parameters + +------------------------------------+---------------------------------------------------------------------------------------------------------------+ | ``auth`` | Auth object, containing your credentials. See :ref:`Auth ` for more details. | +------------------------------------+---------------------------------------------------------------------------------------------------------------+ @@ -177,6 +179,8 @@ To get started, follow the steps below: A connection requires the following parameters: + .. rst-class:: connection-parameters + +------------------------------------+---------------------------------------------------------------------------------------------------------------+ | ``auth`` | Auth object of type FireboltCore. This is a special authentication type that doesn't require credentials. | +------------------------------------+---------------------------------------------------------------------------------------------------------------+ diff --git a/docsrc/_static/custom.css b/docsrc/_static/custom.css new file mode 100644 index 00000000000..035043730e6 --- /dev/null +++ b/docsrc/_static/custom.css @@ -0,0 +1,13 @@ +/* Wrap connection parameter descriptions within the page width. */ +.wy-table-responsive table.connection-parameters { + width: 100%; + table-layout: fixed; +} +.wy-table-responsive table.connection-parameters td, +.wy-table-responsive table.connection-parameters th { + white-space: normal; + overflow-wrap: anywhere; +} +.wy-table-responsive table.connection-parameters td:first-child { + width: 25%; +} diff --git a/docsrc/conf.py b/docsrc/conf.py index 8f57b4088e1..86edb428c53 100644 --- a/docsrc/conf.py +++ b/docsrc/conf.py @@ -64,7 +64,8 @@ # Add any paths that contain custom static files (such as style sheets) here, # relative to this directory. They are copied after the builtin static files, # so a file named "default.css" will overwrite the builtin "default.css". -html_static_path = [] +html_static_path = ["_static"] +html_css_files = ["custom.css"] def qualify_cursor_connections(app, doctree): From 2ac346dc8e048fb6e2dd4900816987858a84e16a Mon Sep 17 00:00:00 2001 From: Simon Zelenski Date: Thu, 29 Oct 2026 16:08:28 +0100 Subject: [PATCH 18/18] style(docs): format Sphinx configuration with Black (FB-5346) --- docsrc/conf.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docsrc/conf.py b/docsrc/conf.py index 86edb428c53..859674fd73c 100644 --- a/docsrc/conf.py +++ b/docsrc/conf.py @@ -74,7 +74,8 @@ def qualify_cursor_connections(app, doctree): for node in doctree.findall(pending_xref): module = node.get("py:module", "") if node.get("reftarget") == "Connection" and module in ( - "firebolt.db.cursor", "firebolt.async_db.cursor" + "firebolt.db.cursor", + "firebolt.async_db.cursor", ): node["reftarget"] = module.removesuffix("cursor") + "connection.Connection"