FDN-2062: Add support for Postgres 15 (#23)

* FDN-2062: Add support for Postgres 15

In Postgres 15, the `pg_class` table does not have `relhasoids`, so
Partman's code from this repository does not work in Postgres 15.
None of our tables were created WITH OIDS, according to the query
shown here and grepping the source code, so just removing the part
that checks for OIDS will work. (This code that I'm removing hasn't
been completely removed in recent versions of Partman, but it is
guarded by a version check.)

The change to `journal.quote_column` reflects type changes from
Postgres 11 to Postgres 15, but also works against Postgres 11 (as
in, this package still builds fine against PG 11 with this change).

The install script needs to grant permissions to the public schema
in Postgres 15.

An additional `Dockerfile-15` has been added to create a Postgres 15
based image. The Travis configuration has been updated to build that
image.

New scripts have been added to recreate the modified functions in
production:
- `journal.quote_column`
- `partman.create_partition_id`
- `partman.create_partition_time`

[so]: https://stackoverflow.com/questions/70257495/postgresql-how-can-i-check-if-table-was-created-with-oids

* update hg check

---------

Co-authored-by: Gregor Heine <gregor@flow.io>

Author: nicolagi

.github/pr-validator.yml

@@ -0,0 +1,38 @@
+name: "PR Title and Description Check"
+on:
+  pull_request:
+    types: [opened, edited, synchronize]
+
+jobs:
+  check-title-and-description:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Check PR title and description
+      uses: actions/github-script@v4
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        script: |
+          const payload = context.payload;
+          const prTitle = payload.pull_request.title;
+          const prDescription = payload.pull_request.body;
+
+          // The pattern for JIRA ticket format
+          const jiraPattern = /\b[A-Z]+-\d+\b|breakglass/gi;
+
+          // Check PR title
+          const hasJiraTitle = jiraPattern.test(prTitle);
+          console.log(`PR title: ${hasJiraTitle ? 'Valid' : 'Invalid'}`);
+
+          // Check PR description
+          const hasJiraDescription = prDescription ? prDescription.match(jiraPattern) : false;
+          console.log(`PR description: ${hasJiraDescription ? 'Valid' : 'Invalid'}`);
+
+          if (hasJiraTitle || hasJiraDescription) {
+            console.log('PR title or description format is correct.');
+          } else {
+            const errorMessage = [];
+            errorMessage.push('The PR title and description do not include a valid JIRA ticket!');
+            console.log(errorMessage.join('\n'));
+
+            core.setFailed(errorMessage.join('\n'));
+          }

.github/workflows/pr-validator.yml

@@ -1,10 +1,12 @@
 # for caching, see: http://www.scala-sbt.org/0.13/docs/Travis-CI-with-sbt.html
 # sudo:false necessary for travis container-based infra, allowing caching
 sudo: false
+dist: jammy
 services:
   - docker
 script:
   - docker build .
+  - docker build -f Dockerfile-15 .
 branches:
   only:
     - main

.travis.yml

@@ -1,4 +1,4 @@
-FROM flowdocker/postgresql:0.1.63
+FROM flowdocker/postgresql:latest
 
 ADD . /opt/schema
 WORKDIR /opt/schema

Dockerfile

@@ -0,0 +1,11 @@
+FROM flowdocker/postgresql15:latest
+
+ADD . /opt/schema
+WORKDIR /opt/schema
+
+RUN service postgresql start && \
+    ./install.sh && \
+    service postgresql stop
+
+USER "postgres"
+CMD ["/usr/lib/postgresql/15/bin/postgres", "-i", "-D", "/var/lib/postgresql/15/main"]

Dockerfile-15

@@ -3,4 +3,5 @@
 psql -U postgres -c 'create database dependencydb' postgres
 psql -U postgres -c 'create role api login PASSWORD NULL' postgres > /dev/null
 psql -U postgres -c 'GRANT ALL ON DATABASE dependencydb TO api' postgres
+psql -U postgres -c 'grant all on schema public to api' dependencydb
 sem-apply --url postgresql://api@localhost/dependencydb

install.sh

@@ -2361,14 +2361,6 @@ FOREACH v_id IN ARRAY p_partition_ids LOOP
             , v_partition_name
             , v_parent_schema
             , v_parent_tablename);
-    SELECT relhasoids INTO v_hasoids
-    FROM pg_catalog.pg_class c
-    JOIN pg_catalog.pg_namespace n ON c.relnamespace = n.oid
-    WHERE c.relname = v_parent_tablename
-    AND n.nspname = v_parent_schema;
-    IF v_hasoids IS TRUE THEN
-        v_sql := v_sql || ' WITH (OIDS)';
-    END IF;
     EXECUTE v_sql;
     IF v_parent_tablespace IS NOT NULL THEN
         EXECUTE format('ALTER TABLE %I.%I SET TABLESPACE %I', v_parent_schema, v_partition_name, v_parent_tablespace);
@@ -2694,14 +2686,6 @@ FOREACH v_time IN ARRAY p_partition_times LOOP
                                 , v_partition_name
                                 , v_parent_schema
                                 , v_parent_tablename);
-    SELECT relhasoids INTO v_hasoids
-    FROM pg_catalog.pg_class c
-    JOIN pg_catalog.pg_namespace n ON c.relnamespace = n.oid
-    WHERE c.relname = v_parent_tablename
-    AND n.nspname = v_parent_schema;
-    IF v_hasoids IS TRUE THEN
-        v_sql := v_sql || ' WITH (OIDS)';
-    END IF;
     EXECUTE v_sql;
     IF v_parent_tablespace IS NOT NULL THEN
         EXECUTE format('ALTER TABLE %I.%I SET TABLESPACE %I', v_parent_schema, v_partition_name, v_parent_tablespace);

scripts/20151107-131159.sql

@@ -1,4 +1,4 @@
-create or replace function journal.quote_column(name in varchar) returns varchar language plpgsql as $$
+create or replace function journal.quote_column(name in information_schema.sql_identifier) returns text language plpgsql as $$
 begin
   return '"' || name || '"';
 end;

scripts/20181029-115650.sql

@@ -0,0 +1,11 @@
+-- Drop the function first, can't replace it because the signature changed.
+-- Can't assume the function exists either (e.g., tokendb doesn't have it).
+DROP FUNCTION IF EXISTS journal.quote_column;
+CREATE FUNCTION journal.quote_column(name information_schema.sql_identifier)
+ RETURNS text
+ LANGUAGE plpgsql
+AS $function$
+begin
+  return '"' || name || '"';
+end;
+$function$