update

Author: chunhtai

packages/devtools_app/lib/src/screens/accessibility/accessibility_controller.dart

@@ -7,7 +7,6 @@ import 'dart:async';
 import 'package:devtools_app_shared/utils.dart';
 import 'package:flutter/foundation.dart';
 
-import '../../shared/diagnostics/diagnostics_node.dart';
 import '../../shared/framework/screen.dart';
 import '../../shared/framework/screen_controllers.dart';
 
@@ -16,10 +15,6 @@ class AccessibilityController extends DevToolsScreenController
   @override
   String get screenId => ScreenMetaData.accessibility.id;
 
-  /// The root node of the semantics tree.
-  ValueListenable<RemoteDiagnosticsNode?> get rootNode => _rootNode;
-  final _rootNode = ValueNotifier<RemoteDiagnosticsNode?>(null);
-
   /// Whether the accessibility feature is enabled.
   ValueListenable<bool> get accessibilityEnabled => _accessibilityEnabled;
   final _accessibilityEnabled = ValueNotifier<bool>(false);
@@ -33,33 +28,22 @@ class AccessibilityController extends DevToolsScreenController
   ValueListenable<bool> get autoAuditEnabled => _autoAuditEnabled;
   final _autoAuditEnabled = ValueNotifier<bool>(false);
 
-  Future<void> toggleAccessibility(bool enable) async {
-    _accessibilityEnabled.value = enable;
-    if (enable) {
-      // TODO(kenz): enable semantics and other accessibility features.
-    } else {
-      // TODO(kenz): disable semantics and other accessibility features.
-    }
-  }
-
   Future<void> setTextScaleFactor(double factor) async {
     _textScaleFactor.value = factor;
-    // TODO(kenz): set text scale factor on device.
+    // TODO(chunhtai): set text scale factor on device.
   }
 
   Future<void> toggleHighContrast(bool enable) async {
     _highContrastEnabled.value = enable;
-    // TODO(kenz): set high contrast on device.
+    // TODO(chunhtai): set high contrast on device.
   }
 
   Future<void> toggleAutoAudit(bool enable) async {
     _autoAuditEnabled.value = enable;
-    if (enable) {
-      await runAudit();
-    }
+    // TODO(chunhtai): auto run audit when enabled.
   }
 
   Future<void> runAudit() async {
-    // TODO(kenz): run accessibility audit.
+    // TODO(chunhtai): run accessibility audit.
   }
 }

packages/devtools_app/test/screens/accessibility/accessibility_screen_test.dart

@@ -1,9 +1,14 @@
+// Copyright 2024 The Flutter Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
+
 import 'package:devtools_app/src/app.dart';
+import 'package:devtools_app/src/screens/accessibility/accessibility_controller.dart';
+import 'package:devtools_app/src/screens/accessibility/accessibility_controls.dart';
+import 'package:devtools_app/src/screens/accessibility/accessibility_results.dart';
 import 'package:devtools_app/src/screens/accessibility/accessibility_screen.dart';
 import 'package:devtools_app/src/service/service_manager.dart';
 import 'package:devtools_app/src/shared/feature_flags.dart';
-import 'package:devtools_app/src/shared/framework/screen.dart';
-import 'package:devtools_app/src/shared/globals.dart';
 import 'package:devtools_app/src/shared/managers/banner_messages.dart';
 import 'package:devtools_app/src/shared/managers/notifications.dart';
 import 'package:devtools_app/src/shared/offline/offline_data.dart';
@@ -16,10 +21,9 @@ import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 
 void main() {
-  const screen = ScreenMetaData.accessibility;
-
   group('AccessibilityScreen', () {
     late FakeServiceConnectionManager fakeServiceConnection;
+    late AccessibilityController controller;
 
     setUp(() {
       fakeServiceConnection = FakeServiceConnectionManager();
@@ -30,6 +34,7 @@ void main() {
       setGlobal(BannerMessagesController, BannerMessagesController());
       setGlobal(PreferencesController, PreferencesController());
       FeatureFlags.accessibility.setEnabledForTests(true);
+      controller = AccessibilityController();
     });
 
     tearDown(() {
@@ -38,12 +43,14 @@ void main() {
 
     testWidgets('builds its body', (WidgetTester tester) async {
       await tester.pumpWidget(
-        wrap(
+        wrapWithControllers(
           Builder(builder: (context) => AccessibilityScreen().build(context)),
+          accessibility: controller,
         ),
       );
       expect(find.byType(AccessibilityScreenBody), findsOneWidget);
-      expect(find.text('Accessibility Screen Placeholder'), findsOneWidget);
+      expect(find.byType(AccessibilityControls), findsOneWidget);
+      expect(find.byType(AccessibilityResults), findsOneWidget);
     });
 
     test('is included in defaultScreens when enabled', () {