Enable unnecessary_async lint rule (#9184)

srawlins · web-flow · commit 158fc57b441b · 2025-05-09T14:35:10.000-07:00
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -127,6 +127,7 @@ linter:
     # - type_annotate_public_apis # subset of always_specify_types
     - type_init_formals
     - unawaited_futures
+    - unnecessary_async
     - unnecessary_brace_in_string_interps
     - unnecessary_const
     - unnecessary_getters_setters
diff --git a/packages/devtools_app/lib/src/screens/inspector_v2/inspector_screen_body.dart b/packages/devtools_app/lib/src/screens/inspector_v2/inspector_screen_body.dart
@@ -65,7 +65,7 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
   }
 
   @override
-  void didChangeDependencies() async {
+  void didChangeDependencies() {
     super.didChangeDependencies();
 
     if (serviceConnection.inspectorService == null) {
diff --git a/packages/devtools_app/lib/src/screens/vm_developer/object_inspector/vm_simple_list_display.dart b/packages/devtools_app/lib/src/screens/vm_developer/object_inspector/vm_simple_list_display.dart
@@ -49,7 +49,7 @@ class _VmSimpleListDisplayState extends State<VmSimpleListDisplay> {
     _initialize();
   }
 
-  void _initialize() async {
+  void _initialize() {
     entries.clear();
     final elementsInstance = widget.vmObject.elementsAsInstance;
     if (elementsInstance != null) {
diff --git a/packages/devtools_app/lib/src/shared/config_specific/drag_and_drop/_drag_and_drop_web.dart b/packages/devtools_app/lib/src/shared/config_specific/drag_and_drop/_drag_and_drop_web.dart
@@ -5,6 +5,7 @@
 import 'dart:async';
 import 'dart:convert';
 import 'dart:js_interop';
+
 import 'package:web/web.dart';
 
 import '../../globals.dart';
@@ -51,7 +52,7 @@ class DragAndDropManagerWeb extends DragAndDropManager {
     dragLeave();
   }
 
-  void _onDrop(MouseEvent event) async {
+  void _onDrop(MouseEvent event) {
     drop();
 
     // Stop the browser from redirecting.
diff --git a/packages/devtools_app/lib/src/shared/framework/routing.dart b/packages/devtools_app/lib/src/shared/framework/routing.dart
@@ -45,7 +45,7 @@ class DevToolsRouteInformationParser
   @override
   Future<DevToolsRouteConfiguration> parseRouteInformation(
     RouteInformation routeInformation,
-  ) async {
+  ) {
     var uri = routeInformation.uri;
     if (_testQueryParams != null) {
       uri = uri.replace(queryParameters: _testQueryParams.params);
diff --git a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart b/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart
@@ -89,7 +89,7 @@ class PropertyEditorController extends DisposableController
 
     // Update in response to ActiveLocationChanged events.
     autoDisposeStreamSubscription(
-      editorClient.activeLocationChangedStream.listen((event) async {
+      editorClient.activeLocationChangedStream.listen((event) {
         if (_waitingForFirstEvent) _waitingForFirstEvent = false;
         final textDocument = event.textDocument;
         final cursorPosition = event.selections.first.active;
diff --git a/packages/devtools_app/test/screens/deep_link_validation/deep_links_screen_test.dart b/packages/devtools_app/test/screens/deep_link_validation/deep_links_screen_test.dart
@@ -36,8 +36,7 @@ final mockProjectRootUris =
         .toList();
 
 void main() {
-  // ignore: avoid-redundant-async, false positive.
-  setUp(() async {
+  setUp(() {
     setGlobal(ServiceConnectionManager, FakeServiceConnectionManager());
     setGlobal(
       DevToolsEnvironmentParameters,
diff --git a/packages/devtools_app/test/screens/deep_link_validation/select_project_view_test.dart b/packages/devtools_app/test/screens/deep_link_validation/select_project_view_test.dart
@@ -19,8 +19,7 @@ import 'package:mockito/mockito.dart';
 import '../../test_infra/utils/deep_links_utils.dart';
 
 void main() {
-  // ignore: avoid-redundant-async, false positive.
-  setUp(() async {
+  setUp(() {
     setGlobal(ServiceConnectionManager, FakeServiceConnectionManager());
     setGlobal(
       DevToolsEnvironmentParameters,
diff --git a/packages/devtools_app/test/screens/memory/diff/widgets/paths_test.dart b/packages/devtools_app/test/screens/memory/diff/widgets/paths_test.dart
@@ -11,7 +11,7 @@ import '../../../../test_infra/scenes/memory/default.dart';
 void main() {
   test('Many retaining paths do not jank UI.', () async {
     final heap = HeapData(
-      await MemoryDefaultSceneHeaps.manyPaths(),
+      MemoryDefaultSceneHeaps.manyPaths(),
       created: DateTime.now(),
     );
     await heap.calculate;
diff --git a/packages/devtools_app/test/screens/memory/framework/memory_service_test.dart b/packages/devtools_app/test/screens/memory/framework/memory_service_test.dart
@@ -27,7 +27,7 @@ void main() {
       const FlutterRunConfiguration(withDebugger: true),
     );
 
-    env.afterNewSetup = () async {
+    env.afterNewSetup = () {
       memoryController = MemoryController();
     };
   }
diff --git a/packages/devtools_app/test/shared/utils/future_work_tracker_test.dart b/packages/devtools_app/test/shared/utils/future_work_tracker_test.dart
@@ -76,7 +76,7 @@ void main() {
     test('tracks failed work', () {
       _wrapAndRunAsync((async) async {
         await runZonedGuarded(
-          () async {
+          () {
             final tracker = FutureWorkTracker();
             expect(tracker.active.value, isFalse);
 
diff --git a/packages/devtools_app/test/standalone_ui/vs_code/devtools_test.dart b/packages/devtools_app/test/standalone_ui/vs_code/devtools_test.dart
@@ -30,8 +30,7 @@ void main() {
     setTestMode();
   });
 
-  // ignore: avoid-redundant-async, false positive.
-  setUp(() async {
+  setUp(() {
     mockEditorClient = MockEditorClient();
     when(mockEditorClient.supportsGetDevices).thenReturn(true);
     when(mockEditorClient.supportsSelectDevice).thenReturn(true);
diff --git a/packages/devtools_app/test/test_infra/scenes/memory/default.dart b/packages/devtools_app/test/test_infra/scenes/memory/default.dart
@@ -33,7 +33,7 @@ extension MemoryDefaultSceneHeaps on Never {
   ///
   /// If sorted by retaining path this class will be the second from the top.
   /// It is needed to measure if selection of this class will cause UI to jank.
-  static Future<HeapSnapshotGraph> manyPaths() async {
+  static HeapSnapshotGraph manyPaths() {
     const pathLen = 100;
     const pathCount = 100;
     final result = FakeHeapSnapshotGraph();
@@ -58,7 +58,7 @@ extension MemoryDefaultSceneHeaps on Never {
           ]
           .map(
             (e) =>
-                () async => FakeHeapSnapshotGraph()..addClassInstances(e),
+                () => FakeHeapSnapshotGraph()..addClassInstances(e),
           )
           .toList();
 
diff --git a/packages/devtools_app/test/test_infra/test_data/memory/heap/heap_data.dart b/packages/devtools_app/test/test_infra/test_data/memory/heap/heap_data.dart
@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 
+import 'dart:async';
+
 import 'package:devtools_app/src/shared/memory/heap_graph_loader.dart';
 import 'package:vm_service/vm_service.dart';
 
@@ -34,7 +36,7 @@ class MockedHeapTest extends HeapTest {
   MockedHeapTest({required super.appClassName});
 
   @override
-  Future<HeapSnapshotGraph> loadHeap() async {
+  Future<HeapSnapshotGraph> loadHeap() {
     throw UnimplementedError();
   }
 }
@@ -55,7 +57,7 @@ class HeapGraphLoaderGoldens implements HeapGraphLoader {
   }
 }
 
-typedef HeapProvider = Future<HeapSnapshotGraph> Function();
+typedef HeapProvider = FutureOr<HeapSnapshotGraph> Function();
 
 /// Provides test snapshots, provided in constructor.
 class HeapGraphLoaderProvided implements HeapGraphLoader {
diff --git a/packages/devtools_app/test/test_infra/utils/deep_links_utils.dart b/packages/devtools_app/test/test_infra/utils/deep_links_utils.dart
@@ -83,7 +83,7 @@ class TestDeepLinksController extends DeepLinksController {
   }
 
   @override
-  void selectLink(LinkData linkdata) async {
+  void selectLink(LinkData linkdata) {
     selectedLink.value = linkdata;
     if (linkdata.domainErrors.isNotEmpty) {
       generatedAssetLinksForSelectedLink.value = GenerateAssetLinksResult(
diff --git a/packages/devtools_app_shared/lib/src/service/service_manager.dart b/packages/devtools_app_shared/lib/src/service/service_manager.dart
@@ -179,7 +179,7 @@ class ServiceManager<T extends VmService> {
     String name, {
     String? isolateId,
     Map<String, dynamic>? args,
-  }) async {
+  }) {
     final registeredMethod = _registeredMethodsForService[name];
     if (registeredMethod == null) {
       throw Exception('There is no registered method for service "$name"');

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`@override`
`68`		`- void didChangeDependencies() async {`
	`68`	`+ void didChangeDependencies() {`
`69`	`69`	`super.didChangeDependencies();`
`70`	`70`
`71`	`71`	`if (serviceConnection.inspectorService == null) {`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ class _VmSimpleListDisplayState extends State<VmSimpleListDisplay> {`
`49`	`49`	`_initialize();`
`50`	`50`	`}`
`51`	`51`
`52`		`- void _initialize() async {`
	`52`	`+ void _initialize() {`
`53`	`53`	`entries.clear();`
`54`	`54`	`final elementsInstance = widget.vmObject.elementsAsInstance;`
`55`	`55`	`if (elementsInstance != null) {`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ void main() {`
`27`	`27`	`const FlutterRunConfiguration(withDebugger: true),`
`28`	`28`	`);`
`29`	`29`
`30`		`- env.afterNewSetup = () async {`
	`30`	`+ env.afterNewSetup = () {`
`31`	`31`	`memoryController = MemoryController();`
`32`	`32`	`};`
`33`	`33`	`}`