address review feedback on _findTestSuiteByRootLibrary

Author: rishika0212

packages/devtools_app_shared/lib/src/service/isolate_manager.dart

@@ -264,6 +264,19 @@ final class IsolateManager with DisposerMixin {
   }
 
   Future<IsolateRef?> _findTestSuiteByRootLibrary(VmService? service) async {
+    String? projectRootUri;
+    if (service != null) {
+      try {
+        final vm = await service.getVM();
+        if (service != _service) return null;
+        // `rootUri` is not a typed field on `VM` in the current vm_service
+        // version, so read it from the raw JSON response.
+        projectRootUri = vm.json?['rootUri'] as String?;
+      } catch (_) {
+        // If getVM() fails, proceed without project-root scoping.
+      }
+    }
+
     for (final isolateState in _isolateStates.values) {
       final isolate = await isolateState.isolate;
       if (service != _service) return null;
@@ -273,25 +286,48 @@ final class IsolateManager with DisposerMixin {
 
       if (_isDartTestRunnerRootLibrary(rootLibraryUri)) continue;
 
-      if (_isLikelyUserTestRootLibrary(rootLibraryUri)) {
+      if (_isLikelyUserTestRootLibrary(
+        rootLibraryUri,
+        projectRootUri: projectRootUri,
+      )) {
         return isolateState.isolateRef;
       }
     }
 
     return null;
   }
 
+  /// Returns true if [uri] looks like the root library of a dart:test runner
+  /// isolate (as opposed to the user's test suite isolate).
+  ///
+  /// Note: 'dart_test.kernel', 'package:test_core/', and 'package:test_api/'
+  /// are implementation details of package:test that DevTools depends on.
+  /// Changing these in package:test will break this logic.
   bool _isDartTestRunnerRootLibrary(String uri) {
     return uri.contains('dart_test.kernel') ||
         uri.startsWith('package:test_core/') ||
         uri.startsWith('package:test_api/');
   }
 
-  bool _isLikelyUserTestRootLibrary(String uri) {
-    return (uri.endsWith('_test.dart') ||
-            uri.contains('/test/') ||
-            uri.contains('\\test\\')) &&
-        !uri.startsWith('dart:');
+  /// Returns true if [uri] looks like the root library of a user test isolate.
+  ///
+  /// When [projectRootUri] is provided, `file://` URIs must be under it to
+  /// avoid false positives from other packages in the workspace that happen to
+  /// contain '/test/' or end with '_test.dart'.
+  bool _isLikelyUserTestRootLibrary(String uri, {String? projectRootUri}) {
+    if (uri.startsWith('dart:')) return false;
+
+    // Scope file:// URIs to the current project to avoid matching test files
+    // from other packages in a workspace.
+    if (projectRootUri != null &&
+        uri.startsWith('file:') &&
+        !uri.startsWith(projectRootUri)) {
+      return false;
+    }
+
+    return uri.endsWith('_test.dart') ||
+        uri.contains('/test/') ||
+        uri.contains('\\test\\');
   }
 
   void _setSelectedIsolate(IsolateRef? ref) {

packages/devtools_app_shared/test/service/isolate_manager_test.dart

@@ -178,11 +178,15 @@ void main() {
 
 /// Minimal fake VmService for IsolateManager tests.
 class _FakeVmService extends Fake implements VmService {
-  _FakeVmService(this.isolates);
+  _FakeVmService(this.isolates, {this.vmRootUri});
 
   /// Map of isolate id -> Isolate to return from getIsolate().
   final Map<String, Isolate> isolates;
 
+  /// Optional root URI returned by [getVM], used to scope test library
+  /// detection to the current project.
+  final String? vmRootUri;
+
   final _isolateEventController = StreamController<Event>.broadcast();
 
   @override
@@ -191,6 +195,14 @@ class _FakeVmService extends Fake implements VmService {
   @override
   Stream<Event> get onDebugEvent => const Stream.empty();
 
+  @override
+  Future<VM> getVM() async {
+    return VM.parse({
+      'type': 'VM',
+      if (vmRootUri != null) 'rootUri': vmRootUri,
+    })!;
+  }
+
   @override
   Future<Isolate> getIsolate(String isolateId) async {
     return isolates[isolateId] ??