Skip to content

Commit 508d1b3

Browse files
authored
Update to latest Flutter candidate version and resolve failing benchmark tests (#9466)
1 parent 1b39a2e commit 508d1b3

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

flutter-candidate.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
86327198ff0678f46cbdfb3e12f1759d03aa768d
1+
c63c6b08a7114517575bcf3e45275ec7a9f4e87f

packages/devtools_app/benchmark/devtools_benchmarks_test.dart

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,12 @@ Future<void> _runBenchmarks({bool useWasm = false}) async {
7575

7676
for (final devToolsBenchmark in DevToolsBenchmark.values) {
7777
final benchmarkName = devToolsBenchmark.id;
78-
final expectedMetrics = expectedBenchmarkMetrics(useWasm: useWasm);
78+
// Note: Due to https://github.com/flutter/flutter/pull/175392 there is no
79+
// longer any difference in benchmark events for skwasm vs. canvaskit.
80+
//
81+
// TODO(https://github.com/flutter/flutter/issues/177057): Remove hardcoded
82+
// useWasm: false param when package:web_benchmarks is updated.
83+
final expectedMetrics = expectedBenchmarkMetrics(useWasm: false);
7984
const expectedComputations = BenchmarkMetricComputation.values;
8085
final scores = taskResult.scores[benchmarkName] ?? [];
8186
expect(

0 commit comments

Comments
 (0)