Enable ColumnData and subclasses to be const (#9326)

Author: parlough

packages/devtools_app/lib/src/screens/app_size/app_size_table.dart

@@ -22,7 +22,7 @@ class AppSizeAnalysisTable extends StatelessWidget {
           ? rootNode.children.first.level
           : rootNode.level,
     );
-    final sizeColumn = _SizeColumn();
+    const sizeColumn = _SizeColumn();
     final columns = List<ColumnData<TreemapNode>>.unmodifiable([
       treeColumn,
       sizeColumn,
@@ -77,7 +77,8 @@ class AppSizeAnalysisTable extends StatelessWidget {
 }
 
 class _NameColumn extends TreeColumnData<TreemapNode> {
-  _NameColumn({required this.currentRootLevel}) : super('Library or Class');
+  const _NameColumn({required this.currentRootLevel})
+    : super('Library or Class');
 
   final int currentRootLevel;
 
@@ -98,7 +99,7 @@ class _NameColumn extends TreeColumnData<TreemapNode> {
 }
 
 class _SizeColumn extends ColumnData<TreemapNode> {
-  _SizeColumn()
+  const _SizeColumn()
     : super('Size', alignment: ColumnAlignment.right, fixedWidthPx: 100.0);
 
   @override
@@ -118,7 +119,7 @@ class _SizeColumn extends ColumnData<TreemapNode> {
 }
 
 class _SizePercentageColumn extends ColumnData<TreemapNode> {
-  _SizePercentageColumn({required this.totalSize})
+  const _SizePercentageColumn({required this.totalSize})
     : super(
         '% of Total Size',
         alignment: ColumnAlignment.right,
@@ -146,7 +147,7 @@ class _SizePercentageColumn extends ColumnData<TreemapNode> {
 class AppSizeDiffTable extends StatelessWidget {
   factory AppSizeDiffTable({required TreemapNode rootNode}) {
     final treeColumn = _NameColumn(currentRootLevel: rootNode.level);
-    final diffColumn = _DiffColumn();
+    const diffColumn = _DiffColumn();
     final columns = List<ColumnData<TreemapNode>>.unmodifiable([
       treeColumn,
       diffColumn,
@@ -188,7 +189,7 @@ class AppSizeDiffTable extends StatelessWidget {
 // TODO(peterdjlee): Add an opaque overlay / background to differentiate from
 //                   other columns.
 class _DiffColumn extends ColumnData<TreemapNode> {
-  _DiffColumn()
+  const _DiffColumn()
     : super('Change', alignment: ColumnAlignment.right, fixedWidthPx: 100.0);
 
   // Ensure sort by absolute size.

packages/devtools_app/lib/src/screens/app_size/code_size_attribution.dart

@@ -211,8 +211,8 @@ class _CallGraphTable extends StatelessWidget {
     required this.onNodeSelected,
   });
 
-  static final _toColumn = ToColumn();
-  static final _fromColumn = FromColumn();
+  static const _toColumn = ToColumn();
+  static const _fromColumn = FromColumn();
 
   final _CallGraphTableType tableType;
 
@@ -240,14 +240,14 @@ class _CallGraphTable extends StatelessWidget {
 }
 
 class FromColumn extends ColumnData<CallGraphNode> {
-  FromColumn() : super.wide('From');
+  const FromColumn() : super.wide('From');
 
   @override
   String getValue(CallGraphNode dataObject) => dataObject.display;
 }
 
 class ToColumn extends ColumnData<CallGraphNode> {
-  ToColumn() : super.wide('To');
+  const ToColumn() : super.wide('To');
 
   @override
   ColumnAlignment get alignment => ColumnAlignment.right;
@@ -260,7 +260,7 @@ class ToColumn extends ColumnData<CallGraphNode> {
 }
 
 class DominatorTree extends StatelessWidget {
-  DominatorTree({
+  const DominatorTree({
     super.key,
     required this.dominatorTreeRoot,
     required this.selectedNode,
@@ -272,7 +272,7 @@ class DominatorTree extends StatelessWidget {
 
   final CallGraphNode? selectedNode;
 
-  final _packageColumn = _PackageColumn();
+  static const _packageColumn = _PackageColumn();
 
   @override
   Widget build(BuildContext context) {
@@ -283,7 +283,7 @@ class DominatorTree extends StatelessWidget {
       dataRoots: [dominatorTreeRoot!],
       dataKey: 'dominator-tree',
       keyFactory: (node) => PageStorageKey<String>('${node.callGraphNode.id}'),
-      columns: [_packageColumn],
+      columns: const [_packageColumn],
       treeColumn: _packageColumn,
       defaultSortColumn: _packageColumn,
       defaultSortDirection: SortDirection.descending,
@@ -304,7 +304,7 @@ class DominatorTree extends StatelessWidget {
 }
 
 class _PackageColumn extends TreeColumnData<DominatorTreeNode> {
-  _PackageColumn() : super('Package');
+  const _PackageColumn() : super('Package');
 
   @override
   String getValue(DominatorTreeNode dataObject) =>

packages/devtools_app/lib/src/screens/deep_link_validation/deep_link_list_view.dart

@@ -207,9 +207,9 @@ class _DataTable extends StatelessWidget {
           ...(() {
             switch (viewType) {
               case TableViewType.domainView:
-                return [domain, NumberOfAssociatedPathColumn()];
+                return [domain, const NumberOfAssociatedPathColumn()];
               case TableViewType.pathView:
-                return [path, NumberOfAssociatedDomainColumn()];
+                return [path, const NumberOfAssociatedDomainColumn()];
               case TableViewType.singleUrlView:
                 return <ColumnData<LinkData>>[domain, path];
             }
@@ -218,7 +218,7 @@ class _DataTable extends StatelessWidget {
           OSColumn(controller),
           if (!controller.displayOptionsNotifier.value.showSplitScreen) ...[
             StatusColumn(controller, viewType),
-            NavigationColumn(),
+            const NavigationColumn(),
           ],
         ],
         selectionNotifier: controller.selectedLink,

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart

@@ -672,15 +672,17 @@ class PathColumn extends ColumnData<LinkData>
 }
 
 class NumberOfAssociatedPathColumn extends ColumnData<LinkData> {
-  NumberOfAssociatedPathColumn() : super.wide('Number of associated path');
+  const NumberOfAssociatedPathColumn()
+    : super.wide('Number of associated path');
 
   @override
   String getValue(LinkData dataObject) =>
       dataObject.associatedPath.length.toString();
 }
 
 class NumberOfAssociatedDomainColumn extends ColumnData<LinkData> {
-  NumberOfAssociatedDomainColumn() : super.wide('Number of associated domain');
+  const NumberOfAssociatedDomainColumn()
+    : super.wide('Number of associated domain');
 
   @override
   String getValue(LinkData dataObject) =>
@@ -741,9 +743,9 @@ class SchemeColumn extends ColumnData<LinkData>
 
 class OSColumn extends ColumnData<LinkData>
     implements ColumnRenderer<LinkData>, ColumnHeaderRenderer<LinkData> {
-  OSColumn(this.controller) : super.wide('OS');
+  const OSColumn(this.controller) : super.wide('OS');
 
-  DeepLinksController controller;
+  final DeepLinksController controller;
 
   @override
   bool get supportsSorting {
@@ -874,7 +876,7 @@ class StatusColumn extends ColumnData<LinkData>
 
 class NavigationColumn extends ColumnData<LinkData>
     implements ColumnRenderer<LinkData> {
-  NavigationColumn() : super('', fixedWidthPx: 40);
+  const NavigationColumn() : super('', fixedWidthPx: 40);
 
   @override
   bool get supportsSorting => false;

packages/devtools_app/lib/src/screens/logging/_logs_table.dart

@@ -29,8 +29,8 @@ class LogsTable extends StatelessWidget {
   final ValueListenable<List<LogData>> searchMatchesNotifier;
   final ValueListenable<LogData?> activeSearchMatchNotifier;
 
-  static final whenColumn = WhenColumn();
-  static final messageColumn = MessageColumn();
+  static const whenColumn = WhenColumn();
+  static const messageColumn = MessageColumn();
   static final columns = [whenColumn, messageColumn];
 
   @override

packages/devtools_app/lib/src/screens/logging/_message_column.dart

@@ -13,7 +13,7 @@ import 'metadata.dart';
 
 class MessageColumn extends ColumnData<LogData>
     implements ColumnRenderer<LogData> {
-  MessageColumn() : super.wide('Log');
+  const MessageColumn() : super.wide('Log');
 
   @override
   bool get supportsSorting => false;

packages/devtools_app/lib/src/screens/logging/_when_column.dart

@@ -6,7 +6,7 @@ import '../../shared/table/table_data.dart';
 import 'logging_controller.dart';
 
 class WhenColumn extends ColumnData<LogData> {
-  WhenColumn() : super('When', fixedWidthPx: 80);
+  const WhenColumn() : super('When', fixedWidthPx: 80);
 
   @override
   bool get supportsSorting => false;

packages/devtools_app/lib/src/screens/memory/panes/diff/widgets/class_details/paths.dart

@@ -15,7 +15,7 @@ import '../../../../shared/primitives/simple_elements.dart';
 import '../../controller/class_data.dart';
 
 class _RetainingPathColumn extends ColumnData<PathData> {
-  _RetainingPathColumn(String className)
+  const _RetainingPathColumn(String className)
     : super.wide(
         'Shortest Retaining Path for Instances of $className',
         titleTooltip:
@@ -33,7 +33,7 @@ class _RetainingPathColumn extends ColumnData<PathData> {
 }
 
 class _InstanceColumn extends ColumnData<PathData> {
-  _InstanceColumn(bool isDiff)
+  const _InstanceColumn(bool isDiff)
     : super(
         isDiff ? 'Instance\nDelta' : 'Instances',
         titleTooltip:

packages/devtools_app/lib/src/screens/memory/panes/diff/widgets/classes_table_diff.dart

@@ -25,7 +25,7 @@ class _ClassNameColumn extends ColumnData<DiffClassData>
     implements
         ColumnRenderer<DiffClassData>,
         ColumnHeaderRenderer<DiffClassData> {
-  _ClassNameColumn(this.diffData)
+  const _ClassNameColumn(this.diffData)
     : super(
         'Class',
         titleTooltip: 'Class name',

packages/devtools_app/lib/src/screens/memory/panes/diff/widgets/classes_table_single.dart

@@ -22,7 +22,7 @@ class _ClassNameColumn extends ColumnData<SingleClassData>
     implements
         ColumnRenderer<SingleClassData>,
         ColumnHeaderRenderer<SingleClassData> {
-  _ClassNameColumn(this.data)
+  const _ClassNameColumn(this.data)
     : super(
         'Class',
         titleTooltip: 'Class name',
@@ -72,7 +72,7 @@ class _ClassNameColumn extends ColumnData<SingleClassData>
 
 class _InstanceColumn extends ColumnData<SingleClassData>
     implements ColumnRenderer<SingleClassData> {
-  _InstanceColumn(this.classData)
+  const _InstanceColumn(this.classData)
     : super(
         'Instances',
         titleTooltip: nonGcableInstancesColumnTooltip,