Combine the pause and resume buttons in the debugger (#9095)

Author: kenzieschmoll

packages/devtools_app/lib/src/screens/debugger/controls.dart

@@ -90,29 +90,32 @@ class _DebuggingControlsState extends State<DebuggingControls>
     required bool resuming,
   }) {
     final isSystemIsolate = controller.isSystemIsolate;
+    // Note: this could be refactored to use a single [GaDevToolsButton] instead
+    // of a [RoundedButtonGroup] with only one child, but this would require
+    // changes to the underlying [DevToolsButton] widget from
+    // package:devtools_app_shared to accept an `iconAsset` as a parameter.
     return RoundedButtonGroup(
       items: [
-        ButtonGroupItemData(
-          tooltip: 'Pause',
-          icon: Icons.pause,
-          autofocus: true,
-          // Disable when paused or selected isolate is a system isolate.
-          onPressed:
-              (isPaused || isSystemIsolate)
-                  ? null
-                  : () => unawaited(controller.pause()),
-        ),
-        ButtonGroupItemData(
-          tooltip: 'Resume',
-          iconAsset: 'icons/material_symbols/resume.png',
-          iconSize: DebuggingControls.materialIconSize,
-          // Enable while paused + not resuming and selected isolate is not
-          // a system isolate.
-          onPressed:
-              ((isPaused && !resuming) && !isSystemIsolate)
-                  ? () => unawaited(controller.resume())
-                  : null,
-        ),
+        !isPaused
+            ? ButtonGroupItemData(
+              tooltip: 'Pause',
+              icon: Icons.pause,
+              autofocus: true,
+              // Disable when selected isolate is a system isolate.
+              onPressed:
+                  isSystemIsolate ? null : () => unawaited(controller.pause()),
+            )
+            : ButtonGroupItemData(
+              tooltip: 'Resume',
+              iconAsset: 'icons/material_symbols/resume.png',
+              iconSize: DebuggingControls.materialIconSize,
+              // Enable not resuming and selected isolate is not a system
+              // isolate.
+              onPressed:
+                  (!resuming && !isSystemIsolate)
+                      ? () => unawaited(controller.resume())
+                      : null,
+            ),
       ],
     );
   }

packages/devtools_app/lib/src/shared/ui/common_widgets.dart

@@ -111,7 +111,7 @@ class GaDevToolsButton extends DevToolsButton {
 class PauseButton extends GaDevToolsButton {
   PauseButton({
     super.key,
-    required super.tooltip,
+    super.tooltip = 'Pause',
     required super.onPressed,
     required super.gaScreen,
     required super.gaSelection,
@@ -124,7 +124,7 @@ class PauseButton extends GaDevToolsButton {
 class ResumeButton extends GaDevToolsButton {
   ResumeButton({
     super.key,
-    required super.tooltip,
+    super.tooltip = 'Resume',
     required super.onPressed,
     required super.gaScreen,
     required super.gaSelection,

packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

@@ -61,7 +61,8 @@ TODO: Remove this section if there are not any general updates.
 
 ## Debugger updates
 
-TODO: Remove this section if there are not any general updates.
+* Combine the Pause and Resume buttons into a single button. -
+[#9095](https://github.com/flutter/devtools/pull/9095)
 
 ## Network profiler updates
 

packages/devtools_app/test/screens/debugger/debugger_screen_paused_test.dart

@@ -88,9 +88,7 @@ void main() {
     await tester.pump();
 
     final pauseButtonFinder = findDebuggerButtonWithIcon(Icons.pause);
-    expect(pauseButtonFinder, findsOneWidget);
-    final pause = getWidgetFromFinder<OutlinedButton>(pauseButtonFinder);
-    expect(pause.onPressed, isNull);
+    expect(pauseButtonFinder, findsNothing);
 
     final resumeButtonFinder = findDebuggerButtonWithIconAsset('resume.png');
     expect(resumeButtonFinder, findsOneWidget);

packages/devtools_app/test/screens/debugger/debugger_screen_test.dart

@@ -133,9 +133,7 @@ void main() {
     expect(pause.onPressed, isNotNull);
 
     final resumeButtonFinder = findDebuggerButtonWithIconAsset('resume.png');
-    expect(resumeButtonFinder, findsOneWidget);
-    final resume = getWidgetFromFinder<OutlinedButton>(resumeButtonFinder);
-    expect(resume.onPressed, isNull);
+    expect(resumeButtonFinder, findsNothing);
   });
 
   testWidgetsWithWindowSize(