Fix deep links page displaying incorrect Windows path formats + a crash if no iOS config (#9027)

This fixes some of the issues noted in #7747, but not all of them (see my comment at #7747 (comment)).

Author: DanTup

packages/devtools_app/lib/src/screens/deep_link_validation/project_root_selection/root_selector.dart

@@ -93,10 +93,27 @@ class _ProjectRootsDropdownState extends State<ProjectRootsDropdown> {
     selectedUri = widget.projectRoots.safeFirst;
   }
 
+  /// A regex that can be matched against the `path` of a URI to check whether
+  /// it is a Windows file URI.
+  final _fileUriWindowsPath = RegExp(r'^/[a-zA-Z](?::|%3A|%3a)');
+
+  /// Gets the file path from a file:/// URI taking into account the platform
+  /// for the path.
+  String toPath(Uri uri) {
+    assert(uri.isScheme('file'));
+
+    // .toFilePath() on web always assumes non-Windows even if the file:/// URI
+    // is Windows, so we need to check whether this is a Windows file path in
+    // the URI first.
+    final isWindows = _fileUriWindowsPath.hasMatch(uri.path);
+    return uri.toFilePath(windows: isWindows);
+  }
+
   @override
   Widget build(BuildContext context) {
+    final selectedUri = this.selectedUri;
     return _FlexibleProjectSelectionView(
-      selectedProjectRoot: selectedUri?.path.trim(),
+      selectedProjectRoot: selectedUri != null ? toPath(selectedUri) : null,
       onValidatePressed: widget.onValidatePressed,
       child: RoundedDropDownButton<Uri>(
         isDense: true,
@@ -105,7 +122,7 @@ class _ProjectRootsDropdownState extends State<ProjectRootsDropdown> {
         items: [for (final uri in widget.projectRoots) _buildMenuItem(uri)],
         onChanged:
             (uri) => setState(() {
-              selectedUri = uri;
+              this.selectedUri = uri;
             }),
       ),
     );
@@ -115,9 +132,9 @@ class _ProjectRootsDropdownState extends State<ProjectRootsDropdown> {
     return DropdownMenuItem<Uri>(
       value: uri,
       child: DevToolsTooltip(
-        message: uri.path,
+        message: toPath(uri),
         waitDuration: tooltipWaitExtraLong,
-        child: Text(uri.path, overflow: TextOverflow.ellipsis),
+        child: Text(toPath(uri), overflow: TextOverflow.ellipsis),
       ),
     );
   }

packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

@@ -77,7 +77,10 @@ TODO: Remove this section if there are not any general updates.
 
 ## Deep links tool updates
 
-TODO: Remove this section if there are not any general updates.
+* Fixed an issue with Windows file paths showing incorrectly in the Deep Links
+page [#9027](https://github.com/flutter/devtools/pull/9027).
+* Fixed an issue with the Deep Links page crashing when no iOS configuration is
+present [#9027](https://github.com/flutter/devtools/pull/9027).
 
 ## VS Code Sidebar updates
 

packages/devtools_app/test/screens/deep_link_validation/deep_links_screen_test.dart

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 
+import 'dart:io';
+
 import 'package:devtools_app/devtools_app.dart';
 import 'package:devtools_app/src/screens/deep_link_validation/deep_link_list_view.dart';
 import 'package:devtools_app/src/screens/deep_link_validation/deep_links_model.dart';
@@ -27,6 +29,13 @@ final xcodeBuildOptions = XcodeBuildOptions.fromJson(
   '''{"configurations":["debug", "release"],"targets":["runner","runnerTests"]}''',
 );
 
+final mockProjectRootUris =
+    (Platform.isWindows
+            ? [r'C:\Users\me\package_root_1', r'C:\Users\me\package_root_2']
+            : ['/Users/me/package_root_1', '/Users/me/package_root_2'])
+        .map(Uri.file)
+        .toList();
+
 void main() {
   // ignore: avoid-redundant-async, false positive.
   setUp(() async {
@@ -40,10 +49,8 @@ void main() {
     setGlobal(NotificationService, NotificationService());
 
     final mockDtdManager = MockDTDManager();
-    final rootUri1 = Uri.parse('file:///Users/me/package_root_1');
-    final rootUri2 = Uri.parse('file:///Users/me/package_root_2');
     when(mockDtdManager.projectRoots()).thenAnswer((_) async {
-      return UriList(uris: [rootUri1, rootUri2]);
+      return UriList(uris: mockProjectRootUris);
     });
     setGlobal(DTDManager, mockDtdManager);
     FeatureFlags.deepLinkIosCheck = true;
@@ -91,6 +98,37 @@ void main() {
       expect(find.byType(ProjectRootTextField), findsOneWidget);
     });
 
+    testWidgetsWithWindowSize(
+      'populates project drop-down with the correct paths',
+      windowSize,
+      (WidgetTester tester) async {
+        await pumpDeepLinkScreen(tester, controller: deepLinksController);
+
+        expect(find.byType(SelectProjectView), findsOneWidget);
+        expect(find.byType(ProjectRootsDropdown), findsOneWidget);
+        expect(find.byType(ProjectRootTextField), findsOneWidget);
+
+        // Verify the project roots dropdown contains paths in the correct format.
+        final firstDropdownItemFinder =
+            find.byType(DropdownMenuItem<Uri>).first;
+        expect(firstDropdownItemFinder, findsWidgets);
+        final firstDropdownItem = tester.widget<DropdownMenuItem<Uri>>(
+          firstDropdownItemFinder,
+        );
+        // The value should be the URI.
+        expect(firstDropdownItem.value, mockProjectRootUris.first);
+        // The text should be the path. We can use toFilePath() here because this
+        // code runs on the native platform (eg. Windows) and not inside the app.
+        expect(
+          find.descendant(
+            of: firstDropdownItemFinder,
+            matching: find.text(mockProjectRootUris.first.toFilePath()),
+          ),
+          findsWidgets,
+        );
+      },
+    );
+
     testWidgetsWithWindowSize(
       'builds deeplink list page with no links',
       windowSize,

packages/devtools_shared/lib/src/deeplink/xcode_build_options.dart

@@ -18,8 +18,9 @@ extension type const XcodeBuildOptions._(Map<String, Object?> _json) {
 
   /// The available configurations for iOS build of this Flutter project.
   List<String> get configurations =>
-      (_json[_kConfigurationsKey] as List).cast<String>();
+      (_json[_kConfigurationsKey] as List?)?.cast<String>() ?? [];
 
   /// The available targets for iOS build of this Flutter project.
-  List<String> get targets => (_json[_kTargetsKey] as List).cast<String>();
+  List<String> get targets =>
+      (_json[_kTargetsKey] as List?)?.cast<String>() ?? [];
 }