Skip to content

Commit cb7d980

Browse files
Create preparing-pr skill (#9752)
* Create `preparing-pr` skill * use relative path
1 parent 45577fa commit cb7d980

1 file changed

Lines changed: 27 additions & 0 deletions

File tree

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
---
2+
name: preparing-pr
3+
description: Prepare a pull request by running presubmit with fixes. Use when preparing to commit or send a PR.
4+
---
5+
6+
# Preparing a Pull Request
7+
8+
Follow these steps to prepare a pull request for DevTools:
9+
10+
1. **Verify `dt` configuration**:
11+
- Ensure `dt` is available on the path by running `dt --help` or verifying its alias.
12+
- If not available, refer to the [CONTRIBUTING guide](../../../CONTRIBUTING.md#L64-L80) for instructions on how to set up the `dt` executable on your path.
13+
2. **Update Flutter SDK**:
14+
- Run `dt update-flutter-sdk` to ensure the SDK is up to date.
15+
3. **Run Presubmit with Fixes**:
16+
- Run `dt presubmit --fix` to address automated fixes.
17+
- If any issues remain or if the command fails, fix the issues manually and run `dt presubmit --fix` again to verify the fix.
18+
4. **Run Tests for Affected Code**:
19+
- Use `git status` or `git diff upstream/master` to find changed files.
20+
- Run tests that are associated with the changed code. For example, if you edited `packages/devtools_app/lib/src/screens/logging/logging_screen.dart`, run the logging tests under `packages/devtools_app/test/screens/logging/`.
21+
22+
## Verification
23+
24+
If any step fails, stop and address the issue, and then verify the issue is fixed before proceeding.
25+
26+
> [!IMPORTANT]
27+
> Do NOT commit or push changes without getting explicit user approval first.

0 commit comments

Comments
 (0)