Small readability tweak in forEachIsolateHelper (#9273)

srawlins · web-flow · commit e6d85577aee7 · 2025-06-24T17:02:27.000-07:00
diff --git a/packages/devtools_app_shared/lib/src/service/service_utils.dart b/packages/devtools_app_shared/lib/src/service/service_utils.dart
@@ -86,8 +86,8 @@ Future<void> forEachIsolateHelper(
   VmService vmService,
   Future<void> Function(IsolateRef) callback,
 ) async {
-  if ((await vmService.getVM()).isolates case final vmIsolates?
-      when vmIsolates.isNotEmpty) {
+  final vm = await vmService.getVM();
+  if (vm.isolates case final vmIsolates? when vmIsolates.isNotEmpty) {
     await [for (final isolate in vmIsolates) callback(isolate)].wait;
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,8 @@ Future<void> forEachIsolateHelper(`
`86`	`86`	`VmService vmService,`
`87`	`87`	`Future<void> Function(IsolateRef) callback,`
`88`	`88`	`) async {`
`89`		`- if ((await vmService.getVM()).isolates case final vmIsolates?`
`90`		`- when vmIsolates.isNotEmpty) {`
	`89`	`+ final vm = await vmService.getVM();`
	`90`	`+ if (vm.isolates case final vmIsolates? when vmIsolates.isNotEmpty) {`
`91`	`91`	`await [for (final isolate in vmIsolates) callback(isolate)].wait;`
`92`	`92`	`}`
`93`	`93`	`}`