Skip to content

Commit f84df3f

Browse files
authored
Correct some broken comment references (#8973)
1 parent c4bd441 commit f84df3f

11 files changed

Lines changed: 41 additions & 38 deletions

File tree

packages/devtools_app/lib/src/app.dart

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -560,18 +560,14 @@ class DevToolsAppState extends State<DevToolsApp> with AutoDisposeMixin {
560560
/// screen's controller, if one exists, as well as enabling offline support.
561561
///
562562
/// [C] corresponds to the type of the screen's controller, which is created by
563-
/// [createController] or provided by [controllerProvider].
563+
/// [createController].
564564
class DevToolsScreen<C extends DevToolsScreenController> {
565565
const DevToolsScreen(this.screen, {this.createController});
566566

567567
final Screen screen;
568568

569569
/// Responsible for creating the controller for this screen, if non-null.
570570
///
571-
/// The controller will then be provided via [controllerProvider], and
572-
/// widgets depending on this controller can access it by calling
573-
/// `Provider<C>.of(context)`.
574-
///
575571
/// If [createController] and `controller` are both null, [screen] will be
576572
/// responsible for creating and maintaining its own controller.
577573
///

packages/devtools_app/lib/src/extensions/extension_service.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class ExtensionService extends DisposableController
4242
/// [ExtensionService] will manage DevTools extensions for.
4343
///
4444
/// When null, [_appRoot] will be calculated from the
45-
/// `serviceConnection.serviceManager`'s currently connected app. See [_initAppRoot].
45+
/// `serviceConnection.serviceManager`'s currently connected app.
4646
final Uri? fixedAppRoot;
4747

4848
/// Whether to ignore the VM service connection for the context of this

packages/devtools_app/lib/src/screens/debugger/codeview_controller.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
44

5+
/// @docImport 'codeview.dart';
6+
library;
7+
58
import 'dart:async';
69
import 'dart:convert';
710

packages/devtools_app/lib/src/screens/network/network_controller.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -549,9 +549,8 @@ class CurrentNetworkRequests extends ValueNotifier<List<NetworkRequest>> {
549549
notifyListeners();
550550
}
551551

552-
/// Update or add the [request] to the [requests] depending on whether or not
553-
/// its [request.id] already exists in the list.
554-
///
552+
/// Updates or adds the [requests] to the [_requestsById] depending on whether
553+
/// or not its `id` already exists in the map.
555554
void _updateOrAddRequests(List<HttpProfileRequest> requests) {
556555
for (int i = 0; i < requests.length; i++) {
557556
final request = requests[i];

packages/devtools_app/lib/src/screens/performance/panes/controls/enhance_tracing/enhance_tracing.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ extension TraceWidgetBuildsScopeExtension on TraceWidgetBuildsScope {
8282
}
8383
}
8484

85-
/// Returns the opposite [TraceWidgetBuildsScope] from [this].
85+
/// Returns the opposite [TraceWidgetBuildsScope] from `this`.
8686
TraceWidgetBuildsScope get opposite {
8787
switch (this) {
8888
case TraceWidgetBuildsScope.all:
@@ -125,11 +125,11 @@ class _TraceWidgetBuildsSettingState extends State<TraceWidgetBuildsSetting>
125125
/// [TraceWidgetBuildsScope] or null if widget builds are not being traced.
126126
final _selectedScope = ValueNotifier<TraceWidgetBuildsScope?>(null);
127127

128-
/// Whether either of the extensions in [_traceWidgetBuildsExtensions.values]
128+
/// Whether either of the extensions in `_traceWidgetBuildsExtensions.values`
129129
/// are enabled.
130130
final _tracingEnabled = ValueNotifier<bool>(false);
131131

132-
/// Whether either of the extensions in [_traceWidgetBuildsExtensions.values]
132+
/// Whether either of the extensions in `_traceWidgetBuildsExtensions.values`
133133
/// are available.
134134
final _tracingAvailable = ValueNotifier<bool>(false);
135135

packages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_controller.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ class FlutterFramesController extends PerformanceFeatureController {
5555
final _pendingFlutterFrames = <FlutterFrame>[];
5656

5757
/// The collection of Flutter frames that have not yet been linked to their
58-
/// respective [TimelineEvent]s for the UI and Raster thread.
58+
/// respective [FlutterTimelineEvent]s for the UI and Raster thread.
5959
///
6060
/// These [FlutterFrame]s are keyed by the Flutter frame ID that matches the
61-
/// frame id in the corresponding [TimelineEvent]s.
61+
/// frame id in the corresponding [FlutterTimelineEvent]s.
6262
final _unassignedFlutterFrames = <int, FlutterFrame>{};
6363

6464
/// Tracks the current frame undergoing selection so that we can equality

packages/devtools_app/lib/src/screens/performance/panes/frame_analysis/frame_hints.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
44

5+
/// @docImport '../flutter_frames/flutter_frame_model.dart';
6+
library;
7+
58
import 'package:devtools_app_shared/ui.dart';
69
import 'package:devtools_app_shared/utils.dart';
710
import 'package:flutter/material.dart';

packages/devtools_app/lib/src/screens/performance/panes/timeline_events/perfetto/_perfetto_controller_web.dart

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
44

5+
/// @docImport '../timeline_events_controller.dart';
6+
/// @docImport '../timeline_events_view.dart';
7+
library;
8+
59
import 'dart:async';
610
import 'dart:ui_web' as ui_web;
711

@@ -29,15 +33,15 @@ const _debugUseLocalPerfetto = false;
2933
///
3034
/// A new instance of [PerfettoController] will be created for each connected
3135
/// app and for each load of offline data. Each time [PerfettoController.init]
32-
/// is called, we create a new [html.IFrameElement] and register it to
33-
/// [PerfettoController.viewId] via
34-
/// [ui_web.platformViewRegistry.registerViewFactory]. Each new [html.IFrameElement]
35-
/// must have a unique id in the [PlatformViewRegistry], which
36-
/// [_viewIdIncrementer] is used to create.
36+
/// is called, we create a new [HTMLIFrameElement] and register it to
37+
/// `PerfettoController.viewId` via
38+
/// [ui_web.PlatformViewRegistry.registerViewFactory]. Each new
39+
/// [HTMLIFrameElement] must have a unique id in the
40+
/// [ui_web.PlatformViewRegistry], which [_viewIdIncrementer] is used to create.
3741
var _viewIdIncrementer = 0;
3842

3943
/// Events that are passed between DevTools and the embedded Perfetto iFrame via
40-
/// [window.postMessage].
44+
/// [Window.postMessage].
4145
enum EmbeddedPerfettoEvent {
4246
/// Id for an event Perfetto expects to verify the trace viewer is ready.
4347
ping('PING'),
@@ -54,7 +58,7 @@ enum EmbeddedPerfettoEvent {
5458
/// re-initialized.
5559
reloadCssConstants('RELOAD-CSS-CONSTANTS'),
5660

57-
/// Id for a [postMessage] request that is sent before trying to change the
61+
/// Id for a `postMessage` request that is sent before trying to change the
5862
/// DevTools theme (see [devtoolsThemeChange]).
5963
///
6064
/// Once the DevTools theme handler in the bundled Perfetto web app has been
@@ -63,11 +67,11 @@ enum EmbeddedPerfettoEvent {
6367
///
6468
/// This message must be sent with the argument 'perfettoIgnore' set to true
6569
/// so that the message handler in the Perfetto codebase
66-
/// [post_message_handler.ts] will not try to handle this message and warn
70+
/// `post_message_handler.ts` will not try to handle this message and warn
6771
/// "Unknown postMessage() event received".
6872
devtoolsThemePing('DART-DEVTOOLS-THEME-PING'),
6973

70-
/// Id for a [postMessage] response that should be received when the DevTools
74+
/// Id for a `postMessage` response that should be received when the DevTools
7175
/// theme handler has been registered.
7276
///
7377
/// We will send a "ping" event [devtoolsThemePing] to the DevTools theme
@@ -76,11 +80,11 @@ enum EmbeddedPerfettoEvent {
7680
/// before we can send a theme change request [devtoolsThemeChange].
7781
devtoolsThemePong('DART-DEVTOOLS-THEME-PONG'),
7882

79-
/// Id for a [postMessage] request that is sent on DevTools theme changes.
83+
/// Id for a `postMessage` request that is sent on DevTools theme changes.
8084
///
8185
/// This message must be sent with the argument 'perfettoIgnore' set to true
8286
/// so that the message handler in the Perfetto codebase
83-
/// [post_message_handler.ts] will not try to handle this message and warn
87+
/// `post_message_handler.ts` will not try to handle this message and warn
8488
/// "Unknown postMessage() event received".
8589
devtoolsThemeChange('DART-DEVTOOLS-THEME-CHANGE');
8690

packages/devtools_app/lib/src/screens/performance/panes/timeline_events/perfetto/_perfetto_web.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,13 @@ class _PerfettoViewController extends DisposableController
109109
bool _perfettoIFrameUnloaded = false;
110110

111111
/// Completes when the Perfetto postMessage handler is ready, which is
112-
/// signaled by receiving a [_perfettoPong] event in response to sending a
113-
/// [_perfettoPing] event.
112+
/// signaled by receiving a `_perfettoPong` event in response to sending a
113+
/// `_perfettoPing` event.
114114
late final Completer<void> _perfettoHandlerReady;
115115

116116
/// Completes when the DevTools theme postMessage handler is ready, which is
117-
/// signaled by receiving a [_devtoolsThemePong] event in response to sending
118-
/// a [_devtoolsThemePing] event.
117+
/// signaled by receiving a `_devtoolsThemePong` event in response to sending
118+
/// a `_devtoolsThemePing` event.
119119
late final Completer<void> _devtoolsThemeHandlerReady;
120120

121121
/// Timer that will poll until [_perfettoHandlerReady] is complete or until

packages/devtools_app/lib/src/screens/profiler/cpu_profile_model.dart

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ class CpuProfileData with Serializable {
550550

551551
factory CpuProfileData.empty() => CpuProfileData.fromJson({});
552552

553-
/// Generates [CpuProfileData] from the provided [CpuSamples].
553+
/// Generates [CpuProfileData] from the provided [cpuSamples].
554554
///
555555
/// [isolateId] The isolate id which was used to get the [cpuSamples].
556556
/// This will be used to tag the stack frames and trace events.
@@ -1015,9 +1015,8 @@ class CpuStackFrame extends TreeNode<CpuStackFrame>
10151015
/// profile, changing the exclusive counts.
10161016
///
10171017
/// When [copySampleCounts] is true, inclusive sample counts are also reset
1018-
/// by default, unless [resetInclusiveSampleCount] is also set to false.
1019-
/// Inclusive sample counts should only be copied as part of a deep copy of
1020-
/// a tree.
1018+
/// by default. Inclusive sample counts should only be copied as part of a
1019+
/// deep copy of a tree.
10211020
@override
10221021
CpuStackFrame shallowCopy({
10231022
String? id,
@@ -1063,7 +1062,7 @@ class CpuStackFrame extends TreeNode<CpuStackFrame>
10631062
return copy;
10641063
}
10651064

1066-
/// Whether [this] stack frame matches another stack frame [other].
1065+
/// Whether `this` stack frame matches another stack frame [other].
10671066
///
10681067
/// Two stack frames are said to be matching if they share the following
10691068
/// properties.

0 commit comments

Comments
 (0)