diff --git a/analysis_options.yaml b/analysis_options.yaml index d6dd068cd84..e57f4c29d8e 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -164,8 +164,6 @@ dart_code_metrics: # TODO(https://github.com/flutter/devtools/issues/9906) remove these # excludes as findings are resolved. - integration_test/** - - lib/src/extensions/** - - lib/src/framework/** - lib/src/screens/** - lib/src/service/** - lib/src/shared/** diff --git a/packages/devtools_app/lib/src/extensions/embedded/_controller_web.dart b/packages/devtools_app/lib/src/extensions/embedded/_controller_web.dart index 388fe7ab9d8..bdcc3f16bf0 100644 --- a/packages/devtools_app/lib/src/extensions/embedded/_controller_web.dart +++ b/packages/devtools_app/lib/src/extensions/embedded/_controller_web.dart @@ -78,6 +78,7 @@ class EmbeddedExtensionControllerImpl extends EmbeddedExtensionController final extensionPostEventStream = StreamController.broadcast(); + // ignore: unused-code, TODO(https://github.com/flutter/devtools/issues/9907): false positive. bool _initialized = false; @override diff --git a/packages/devtools_app/lib/src/extensions/embedded/_view_desktop.dart b/packages/devtools_app/lib/src/extensions/embedded/_view_desktop.dart index 5d9403f6ce8..051461bbbe0 100644 --- a/packages/devtools_app/lib/src/extensions/embedded/_view_desktop.dart +++ b/packages/devtools_app/lib/src/extensions/embedded/_view_desktop.dart @@ -7,9 +7,10 @@ import 'package:flutter/material.dart'; import 'controller.dart'; class EmbeddedExtension extends StatelessWidget { - const EmbeddedExtension({super.key, required this.controller}); - - final EmbeddedExtensionController controller; + const EmbeddedExtension({ + super.key, + required EmbeddedExtensionController controller, + }); @override Widget build(BuildContext context) { diff --git a/packages/devtools_app/lib/src/extensions/extension_service.dart b/packages/devtools_app/lib/src/extensions/extension_service.dart index 2c7513b48ca..ae49a3b7022 100644 --- a/packages/devtools_app/lib/src/extensions/extension_service.dart +++ b/packages/devtools_app/lib/src/extensions/extension_service.dart @@ -70,6 +70,7 @@ class ExtensionService extends DisposableController /// /// This set of extensions will include one version of a DevTools extension /// per package. + @visibleForTesting List get availableExtensions => _currentExtensions.value.availableExtensions; diff --git a/packages/devtools_app/lib/src/framework/home_screen.dart b/packages/devtools_app/lib/src/framework/home_screen.dart index 7b02646f24e..c3fceb32168 100644 --- a/packages/devtools_app/lib/src/framework/home_screen.dart +++ b/packages/devtools_app/lib/src/framework/home_screen.dart @@ -32,8 +32,6 @@ class HomeScreen extends Screen { titleGenerator: () => devToolsTitle.value, ); - static final id = ScreenMetaData.home.id; - final List sampleData; @override @@ -165,10 +163,7 @@ class _ConnectInputState extends State with BlockingActionMixin { void initState() { super.initState(); connectDialogController = TextEditingController(); - assert(() { - _debugInitVmServiceCache(); - return true; - }()); + if (kDebugMode) _debugInitVmServiceCache(); } void _debugInitVmServiceCache() async { diff --git a/packages/devtools_app/lib/src/framework/release_notes.dart b/packages/devtools_app/lib/src/framework/release_notes.dart index f6ea52ca9aa..f7632c6eaf0 100644 --- a/packages/devtools_app/lib/src/framework/release_notes.dart +++ b/packages/devtools_app/lib/src/framework/release_notes.dart @@ -28,6 +28,7 @@ bool debugTestReleaseNotes = false; // from the flutter/website PR, which has a GitHub action that automatically // stages commits to firebase. Example: // https://flutter-docs-prod--pr12652-devtools-release-notes-2-52-3bbb8c0u.web.app/tools/devtools/release-notes/release-notes-2.52.0.md. +// ignore: unused-code, debug-only feature. String? _debugReleaseNotesUrl; const releaseNotesKey = Key('release_notes'); diff --git a/packages/devtools_app/lib/src/framework/scaffold/status_line.dart b/packages/devtools_app/lib/src/framework/scaffold/status_line.dart index 16133d36a29..54e78dc2954 100644 --- a/packages/devtools_app/lib/src/framework/scaffold/status_line.dart +++ b/packages/devtools_app/lib/src/framework/scaffold/status_line.dart @@ -37,8 +37,6 @@ class StatusLine extends StatelessWidget { /// Whether to highlight the footer when DevTools is connected to an app. final bool highlightForConnection; - static const deviceInfoTooltip = 'Device Info'; - /// The padding around the footer in the DevTools UI. EdgeInsets get padding => const EdgeInsets.symmetric( horizontal: defaultSpacing,