fix(registry-page): normalize the link to the registry page between the badge and package.json

Author: travi

src/project-type/publishable/badges.js

@@ -4,14 +4,14 @@ function buildNpmBadgeImageUrl(packageName, customRegistry) {
   return `https://img.shields.io/npm/v/${packageName}?${params}`;
 }
 
-export default function scaffoldPublishableBadges({packageName, accessLevel, customRegistry}) {
+export default function scaffoldPublishableBadges({packageName, accessLevel, customRegistry, registryPage}) {
   return {
     consumer: {
       ...'public' === accessLevel && {
         npm: {
           img: buildNpmBadgeImageUrl(packageName, customRegistry),
           text: 'npm',
-          link: `https://www.npmjs.com/package/${packageName}`
+          link: registryPage
         }
       }
     },

src/project-type/publishable/badges.test.js

@@ -5,24 +5,33 @@ import defineBadges from './badges.js';
 
 describe('badges for publishable project types', async () => {
   const packageName = any.word();
+  const registryPage = any.url();
   const npmBadgeDetails = {
     img: `https://img.shields.io/npm/v/${packageName}?logo=npm`,
     text: 'npm',
-    link: `https://www.npmjs.com/package/${packageName}`
+    link: registryPage
   };
 
-  it('should define the badges when the access level is not public', () => {
-    expect(defineBadges(packageName)).toEqual({consumer: {}, status: {}});
+  it('should note define the badges when the access level is not public', () => {
+    expect(defineBadges({packageName})).toEqual({consumer: {}, status: {}});
   });
 
   it('should return the npm badge for packages with a public access level', () => {
-    expect(defineBadges({packageName, accessLevel: 'public'}).consumer).toEqual({npm: npmBadgeDetails});
+    expect(defineBadges({
+      packageName,
+      accessLevel: 'public',
+      registryPage
+    }).consumer).toEqual({npm: npmBadgeDetails});
   });
 
   it('should include the registry_uri in the npm badge when a custom registry is provided', () => {
     const customRegistry = any.url();
 
-    const {searchParams} = new URL(defineBadges({packageName, accessLevel: 'public', customRegistry}).consumer.npm.img);
+    const {searchParams} = new URL(defineBadges({
+      packageName,
+      accessLevel: 'public',
+      customRegistry
+    }, `https://www.npmjs.com/package/${packageName}`).consumer.npm.img);
 
     expect(searchParams.get('registry_uri')).toEqual(customRegistry);
   });

src/project-type/publishable/lifter.js

@@ -8,17 +8,22 @@ import {lift as liftProvenance} from './provenance/index.js';
 export default async function liftPublishable({projectRoot, packageDetails, configs}) {
   const {name: packageName, publishConfig: {access: packageAccessLevel}} = packageDetails;
   const customRegistry = resolveRegistry(packageName, configs.registries);
-  const homepage = `https://npm.im/${packageName}`;
+  const registryPage = `https://www.npmjs.com/package/${packageName}`;
 
-  await mergeIntoExistingPackageJson({projectRoot, config: {homepage}});
+  await mergeIntoExistingPackageJson({projectRoot, config: {homepage: registryPage}});
 
   return deepmerge(
     await liftProvenance({packageDetails, projectRoot, customRegistry}),
     {
-      homepage,
+      homepage: registryPage,
       dependencies: {javascript: {development: ['publint']}},
       scripts: {'lint:publish': 'publint --strict'},
-      badges: defineBadges({packageName, accessLevel: packageAccessLevel, customRegistry})
+      badges: defineBadges({
+        packageName,
+        accessLevel: packageAccessLevel,
+        customRegistry,
+        registryPage
+      })
     }
   );
 }

src/project-type/publishable/lifter.test.js

@@ -27,23 +27,23 @@ describe('publishable project-type lifter', () => {
     const provenanceResults = any.simpleObject();
     const mergedResults = any.simpleObject();
     const badgesResults = any.simpleObject();
-    const homepage = `https://npm.im/${packageName}`;
+    const registryPage = `https://www.npmjs.com/package/${packageName}`;
     when(resolveRegistry).calledWith(packageName, registries).thenReturn(customRegistry);
     when(liftProvenance).calledWith({packageDetails, projectRoot, customRegistry}).thenResolve(provenanceResults);
     when(defineBadges)
-      .calledWith({packageName, accessLevel: packageAccessLevel, customRegistry})
+      .calledWith({packageName, accessLevel: packageAccessLevel, customRegistry, registryPage})
       .thenReturn(badgesResults);
     when(deepmerge).calledWith(
       provenanceResults,
       {
         scripts: {'lint:publish': 'publint --strict'},
         dependencies: {javascript: {development: ['publint']}},
         badges: badgesResults,
-        homepage
+        homepage: registryPage
       }
     ).thenReturn(mergedResults);
 
     expect(await lift({projectRoot, packageDetails, configs: {registries}})).toEqual(mergedResults);
-    expect(mergeIntoExistingPackageJson).toHaveBeenCalledWith({projectRoot, config: {homepage}});
+    expect(mergeIntoExistingPackageJson).toHaveBeenCalledWith({projectRoot, config: {homepage: registryPage}});
   });
 });

test/integration/features/step_definitions/project-type-steps.js

@@ -9,7 +9,7 @@ import any from '@travi/any';
 export function assertHomepageDefinedProperly(homepage, projectType, projectName, npmAccount, vcs) {
   if ([projectTypes.PACKAGE, projectTypes.CLI].includes(projectType)) {
     const packageName = `@${npmAccount}/${projectName}`;
-    assert.equal(homepage, `https://npm.im/${packageName}`);
+    assert.equal(homepage, `https://www.npmjs.com/package/${packageName}`);
   } else if (vcs && 'github' === vcs.host) {
     assert.equal(homepage, `https://github.com/${vcs.owner}/${vcs.name}#readme`);
   } else if (!vcs) {