Skip to content

Commit ccf0d4e

Browse files
Apply migration from 0.18.0 to 0.19.0
=== v0.19.0 ========================================================= Script URL: https://raw.githubusercontent.com/frequenz-floss/frequenz-repo-config-python/v0.19.0/cookiecutter/migrate.py ======================================================================== Enabling exhaustive match checks for mypy... Updated pyproject.toml: enabled exhaustive-match ======================================================================== ======================================================================== Removing default `-vv` from pytest addopts... >>> pyproject.toml has a customized `addopts = "-W=all -Werror -Wdefault::DeprecationWarning -Wdefault::PendingDeprecationWarning -vv"` line under [tool.pytest.ini_options]; please drop `-vv` from it manually if appropriate. ======================================================================== Removing the dummy DCO merge-queue workflow... Removed .github/workflows/dco-merge-queue.yml ======================================================================== Pinning the DCO check in the 'Protect version branches' ruleset... Updated ruleset 'Protect version branches': pin 'DCO' status check to the DCO app ======================================================================== ======================================================================== Updating pinned build dependencies... Updated pyproject.toml: bumped setuptools to 84.0.0 ======================================================================== ======================================================================== Enabling asyncio debug mode for pytest... Updated pyproject.toml: enabled asyncio debug mode under [tool.pytest.ini_options] ======================================================================== ======================================================================== Updating the release instructions in CONTRIBUTING.md... Updated CONTRIBUTING.md: refreshed the release instructions ======================================================================== ⚠️⚠️⚠️ Remember to check the manual steps: ⚠️⚠️⚠️ ⚠️⚠️⚠️ 1. pyproject.toml has a customized `addopts = "-W=all -Werror -Wdefault::DeprecationWarning -Wdefault::PendingDeprecationWarning -vv"` line under [tool.pytest.ini_options]; please drop `-vv` from it manually if appropriate. ❌ Migration script finished but requires manual intervention ❌ The migration completed but requires manual intervention. Applied-by: frequenz-floss/gh-action-dependabot-migrate
1 parent 0a7d17d commit ccf0d4e

3 files changed

Lines changed: 20 additions & 18 deletions

File tree

‎.github/workflows/dco-merge-queue.yml‎

Lines changed: 0 additions & 14 deletions
This file was deleted.

‎CONTRIBUTING.md‎

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ Or you can use `nox`:
5353
nox -R -s pytest -- tests/test_*.py
5454
```
5555

56-
The same appliest to `pylint` or `mypy` for example:
56+
The same applies to `pylint` or `mypy` for example:
5757

5858
```sh
5959
nox -R -s pylint -- tests/test_*.py
@@ -121,12 +121,19 @@ These are the steps to create a new release:
121121

122122
1. Get the latest head you want to create a release from.
123123

124+
If you use milestones, check that the milestone for this release has no open
125+
issues left, and move whatever won't make it to a later milestone.
126+
124127
2. Update the `RELEASE_NOTES.md` file if it is not complete, up to date, and
125-
remove template comments (`<!-- ... ->`) and empty sections. Submit a pull
128+
remove template comments (`<!-- ... -->`) and empty sections. Submit a pull
126129
request if an update is needed, wait until it is merged, and update the
127130
latest head you want to create a release from to get the new merged pull
128131
request.
129132

133+
This can't be left for later: the notes published with the release are read
134+
from the `RELEASE_NOTES.md` committed at the tagged commit, not from the tag
135+
message.
136+
130137
3. Create a new signed tag using the release notes and
131138
a [semver](https://semver.org/) compatible version number with a `v` prefix,
132139
for example:
@@ -135,6 +142,10 @@ These are the steps to create a new release:
135142
git tag -s --cleanup=whitespace -F RELEASE_NOTES.md v0.0.1
136143
```
137144

145+
The signature is not optional: the *Protect released tags* ruleset rejects
146+
unsigned tags. It also forbids updating or deleting a released tag, so make
147+
sure you are tagging the commit you want.
148+
138149
4. Push the new tag.
139150

140151
5. A GitHub action will test the tag and if all goes well it will create
@@ -153,4 +164,7 @@ These are the steps to create a new release:
153164
Commit the new release notes and create a PR (this step should be automated
154165
eventually too).
155166

156-
7. Celebrate!
167+
7. If you use milestones, close the milestone for this release, and create the
168+
next one if it doesn't exist yet.
169+
170+
8. Celebrate!

‎pyproject.toml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
[build-system]
55
requires = [
6-
"setuptools == 83.0.0",
6+
"setuptools == 84.0.0",
77
"setuptools_scm[toml] == 10.2.1",
88
"frequenz-repo-config[lib] == 0.19.0",
99
]
@@ -162,11 +162,13 @@ disable = [
162162
[tool.pytest.ini_options]
163163
addopts = "-W=all -Werror -Wdefault::DeprecationWarning -Wdefault::PendingDeprecationWarning -vv"
164164
testpaths = ["tests", "src"]
165+
asyncio_debug = true
165166
asyncio_mode = "auto"
166167
asyncio_default_fixture_loop_scope = "function"
167168
required_plugins = ["pytest-asyncio", "pytest-mock"]
168169

169170
[tool.mypy]
171+
enable_error_code = ["exhaustive-match"]
170172
explicit_package_bases = true
171173
namespace_packages = true
172174
# This option disables mypy cache, and it is sometimes useful to enable it if

0 commit comments

Comments
 (0)