Skip to content

Commit 274ffb1

Browse files
forkiKevinRansom
authored andcommitted
Use more specific assertions in CompilerAssert (#7122)
1 parent 20690ca commit 274ffb1

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

tests/fsharp/Compiler/CompilerAssert.fs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,25 +54,26 @@ module CompilerAssert =
5454
lock lockObj <| fun () ->
5555
let parseResults, fileAnswer = checker.ParseAndCheckFileInProject("test.fs", 0, SourceText.ofString source, defaultProjectOptions) |> Async.RunSynchronously
5656

57-
Assert.True(parseResults.Errors.Length = 0, sprintf "Parse errors: %A" parseResults.Errors)
57+
Assert.IsEmpty(parseResults.Errors, sprintf "Parse errors: %A" parseResults.Errors)
5858

5959
match fileAnswer with
6060
| FSharpCheckFileAnswer.Aborted _ -> Assert.Fail("Type Checker Aborted")
6161
| FSharpCheckFileAnswer.Succeeded(typeCheckResults) ->
6262

63-
Assert.True(typeCheckResults.Errors.Length = 0, sprintf "Type Check errors: %A" typeCheckResults.Errors)
63+
Assert.IsEmpty(typeCheckResults.Errors, sprintf "Type Check errors: %A" typeCheckResults.Errors)
64+
6465

6566
let TypeCheckSingleError (source: string) (expectedErrorNumber: int) (expectedErrorRange: int * int * int * int) (expectedErrorMsg: string) =
6667
lock lockObj <| fun () ->
6768
let parseResults, fileAnswer = checker.ParseAndCheckFileInProject("test.fs", 0, SourceText.ofString source, defaultProjectOptions) |> Async.RunSynchronously
6869

69-
Assert.True(parseResults.Errors.Length = 0, sprintf "Parse errors: %A" parseResults.Errors)
70+
Assert.IsEmpty(parseResults.Errors, sprintf "Parse errors: %A" parseResults.Errors)
7071

7172
match fileAnswer with
7273
| FSharpCheckFileAnswer.Aborted _ -> Assert.Fail("Type Checker Aborted")
7374
| FSharpCheckFileAnswer.Succeeded(typeCheckResults) ->
7475

75-
Assert.True(typeCheckResults.Errors.Length = 1, sprintf "Expected one type check error: %A" typeCheckResults.Errors)
76+
Assert.AreEqual(1, typeCheckResults.Errors.Length, sprintf "Expected one type check error: %A" typeCheckResults.Errors)
7677
typeCheckResults.Errors
7778
|> Array.iter (fun info ->
7879
Assert.AreEqual(FSharpErrorSeverity.Error, info.Severity)

0 commit comments

Comments
 (0)