Moved some fsharpqa Test Cases over to NUnit (#9254)

* Migrated 'missing expression after let' testcase

* Fixed naming of file

* Migrated 'Wrong Numeric Literal' testcase

* Moved new files to bottom in folder

* Migrated 'module abbreviations are always private' testcase

* Fixed test naming

* Unlisted migrated testcases from env.lst

Author: ThorstenReichert

tests/fsharp/Compiler/ErrorMessages/InvalidNumericLiteralTests.fs

@@ -0,0 +1,20 @@
+// Copyright (c) Microsoft Corporation.  All Rights Reserved.  See License.txt in the project root for license information.
+
+namespace FSharp.Compiler.UnitTests
+
+open NUnit.Framework
+open FSharp.Compiler.SourceCodeServices
+
+[<TestFixture>]
+module ``Invalid Numeric Literal`` =
+
+    [<Test>]
+    let ``1up is invalid Numeric Literal``() =
+        CompilerAssert.TypeCheckSingleError
+            """
+let foo = 1up // int
+            """
+            FSharpErrorSeverity.Error
+            1156
+            (2, 11, 2, 14)
+            "This is not a valid numeric literal. Valid numeric literals include 1, 0x1, 0o1, 0b1, 1l (int), 1u (uint32), 1L (int64), 1UL (uint64), 1s (int16), 1y (sbyte), 1uy (byte), 1.0 (float), 1.0f (float32), 1.0m (decimal), 1I (BigInteger)."

tests/fsharp/Compiler/ErrorMessages/MissingExpressionTests.fs

@@ -0,0 +1,22 @@
+// Copyright (c) Microsoft Corporation.  All Rights Reserved.  See License.txt in the project root for license information.
+
+namespace FSharp.Compiler.UnitTests
+
+open NUnit.Framework
+open FSharp.Compiler.SourceCodeServices
+
+[<TestFixture>]
+module ``Missing Expression`` =
+    
+    [<Test>]
+    let ``Missing Expression after let``() =
+        CompilerAssert.TypeCheckSingleError
+            """
+let sum = 0
+for x in 0 .. 10 do
+    let sum = sum + x
+            """
+            FSharpErrorSeverity.Error
+            588
+            (4,5,4,8)
+            "The block following this 'let' is unfinished. Every code block is an expression and must have a result. 'let' cannot be the final code element in a block. Consider giving this block an explicit result."

tests/fsharp/Compiler/ErrorMessages/ModuleAbbreviationTests.fs

@@ -0,0 +1,20 @@
+// Copyright (c) Microsoft Corporation.  All Rights Reserved.  See License.txt in the project root for license information.
+
+namespace FSharp.Compiler.UnitTests
+
+open NUnit.Framework
+open FSharp.Compiler.SourceCodeServices
+
+[<TestFixture>]
+module ``Module Abbreviations`` =
+
+    [<Test>]
+    let ``Public Module Abbreviation``() =
+        CompilerAssert.TypeCheckSingleError
+            """
+module public L1 = List
+            """
+            FSharpErrorSeverity.Error
+            536
+            (2, 1, 2, 7)
+            "The 'Public' accessibility attribute is not allowed on module abbreviation. Module abbreviations are always private."

tests/fsharp/FSharpSuite.Tests.fsproj

@@ -52,6 +52,9 @@
     <Compile Include="Compiler\ErrorMessages\WrongSyntaxInForLoop.fs" />
     <Compile Include="Compiler\ErrorMessages\WarnExpressionTests.fs" />
     <Compile Include="Compiler\ErrorMessages\DontSuggestTests.fs" />
+    <Compile Include="Compiler\ErrorMessages\MissingExpressionTests.fs" />
+    <Compile Include="Compiler\ErrorMessages\InvalidNumericLiteralTests.fs" />
+    <Compile Include="Compiler\ErrorMessages\ModuleAbbreviationTests.fs" />
     <Compile Include="Compiler\Warnings\AssignmentWarningTests.fs" />
     <Compile Include="Compiler\Warnings\ExperimentalAttributeTests.fs" />
     <Compile Include="Compiler\Warnings\PatternMatchingWarningTests.fs" />

tests/fsharpqa/Source/Warnings/MissingExpressionAfterLet.fs

@@ -1,5 +1,2 @@
-	SOURCE=WrongNumericLiteral.fs # WrongNumericLiteral.fs
 	SOURCE=FS0988AtEndOfFile.fs # FS0988AtEndOfFile.fs
-	SOURCE=MissingExpressionAfterLet.fs # MissingExpressionAfterLet.fs
 	SOURCE=Repro1548.fs SCFLAGS="-r:Repro1548.dll"				# Repro1548.fs
-	SOURCE=ModuleAbbreviationsArePrivate.fs