Skip to content

Commit b024d51

Browse files
codereview: redefine order of ILMemberAccess to match roslyn codebase
1 parent 1ccb4b1 commit b024d51

3 files changed

Lines changed: 14 additions & 14 deletions

File tree

src/absil/il.fs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1245,10 +1245,10 @@ type ILMethodBody =
12451245
type ILMemberAccess =
12461246
| CompilerControlled
12471247
| Private
1248-
| FamilyAndAssembly
1249-
| Assembly
1250-
| FamilyOrAssembly
1251-
| Family
1248+
| FamilyAndAssembly // protected and internal
1249+
| Family // protected
1250+
| Assembly // internal
1251+
| FamilyOrAssembly // protected or internal
12521252
| Public
12531253

12541254
[<RequireQualifiedAccess; StructuralEquality; StructuralComparison>]

src/absil/il.fsi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -732,10 +732,10 @@ type ILMethodBody =
732732
type ILMemberAccess =
733733
| CompilerControlled
734734
| Private
735-
| FamilyAndAssembly
736-
| Assembly
737-
| FamilyOrAssembly
738-
| Family
735+
| FamilyAndAssembly // protected and internal
736+
| Family // protected
737+
| Assembly // internal
738+
| FamilyOrAssembly // protected or internal
739739
| Public
740740

741741
[<RequireQualifiedAccess>]

tests/fsharp/Compiler/ILMemberAccessTests.fs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,24 +38,24 @@ module ILMemberAccessTests =
3838
else
3939
failwithf "%A > %A didn't hold" a b
4040

41-
compareIsGreater ILMemberAccess.Public ILMemberAccess.Family
4241
compareIsGreater ILMemberAccess.Public ILMemberAccess.FamilyOrAssembly
42+
compareIsGreater ILMemberAccess.Public ILMemberAccess.Family
4343
compareIsGreater ILMemberAccess.Public ILMemberAccess.Assembly
4444
compareIsGreater ILMemberAccess.Public ILMemberAccess.FamilyAndAssembly
4545
compareIsGreater ILMemberAccess.Public ILMemberAccess.Private
4646
compareIsGreater ILMemberAccess.Public ILMemberAccess.CompilerControlled
47-
compareIsGreater ILMemberAccess.Family ILMemberAccess.FamilyOrAssembly
48-
compareIsGreater ILMemberAccess.Family ILMemberAccess.Assembly
49-
compareIsGreater ILMemberAccess.Family ILMemberAccess.FamilyAndAssembly
50-
compareIsGreater ILMemberAccess.Family ILMemberAccess.Private
51-
compareIsGreater ILMemberAccess.Family ILMemberAccess.CompilerControlled
5247
compareIsGreater ILMemberAccess.FamilyOrAssembly ILMemberAccess.Assembly
48+
compareIsGreater ILMemberAccess.FamilyOrAssembly ILMemberAccess.Family
5349
compareIsGreater ILMemberAccess.FamilyOrAssembly ILMemberAccess.FamilyAndAssembly
5450
compareIsGreater ILMemberAccess.FamilyOrAssembly ILMemberAccess.Private
5551
compareIsGreater ILMemberAccess.FamilyOrAssembly ILMemberAccess.CompilerControlled
52+
compareIsGreater ILMemberAccess.Assembly ILMemberAccess.Family
5653
compareIsGreater ILMemberAccess.Assembly ILMemberAccess.FamilyAndAssembly
5754
compareIsGreater ILMemberAccess.Assembly ILMemberAccess.Private
5855
compareIsGreater ILMemberAccess.Assembly ILMemberAccess.CompilerControlled
56+
compareIsGreater ILMemberAccess.Family ILMemberAccess.FamilyAndAssembly
57+
compareIsGreater ILMemberAccess.Family ILMemberAccess.Private
58+
compareIsGreater ILMemberAccess.Family ILMemberAccess.CompilerControlled
5959
compareIsGreater ILMemberAccess.FamilyAndAssembly ILMemberAccess.Private
6060
compareIsGreater ILMemberAccess.FamilyAndAssembly ILMemberAccess.CompilerControlled
6161
compareIsGreater ILMemberAccess.Private ILMemberAccess.CompilerControlled

0 commit comments

Comments
 (0)