Fix srtp constraint printing (#9728)

* Fix #5768
Corrected wrong formatted print of a trait member constraint

Signed-off-by: realvictorprm <mueller.vpr@gmail.com>

* Adding regression test.

Signed-off-by: realvictorprm <mueller.vpr@gmail.com>

* Fix test to expect an error.

Signed-off-by: realvictorprm <mueller.vpr@gmail.com>

* Apply review, move and add new test to typecheck\sigs.

Signed-off-by: realvictorprm <mueller.vpr@gmail.com>

* Rename neg111 to neg112 to ease merging

* Bring layoutReturnType into scope, and use instead of layoutTypeWithInfoAndPrec

* Fix test neg112 to use proper directory

* Fix tests that suggest overloads to use parens around returned functions

* Mention correct file and col numbers in new neg112 test

Co-authored-by: realvictorprm <mueller.vpr@gmail.com>

Author: 2 people

src/fsharp/NicePrint.fs

@@ -892,7 +892,7 @@ module private PrintTypes =
                 | tys -> bracketL (layoutTypesWithInfoAndPrec denv env 2 (wordL (tagKeyword "or")) tys)
             tysL ^^ wordL (tagPunctuation ":") ---
                 bracketL (stat ++ wordL (tagMember nm) ^^ wordL (tagPunctuation ":") ---
-                        ((layoutTypesWithInfoAndPrec denv env 2 (wordL (tagPunctuation "*")) argtys --- wordL (tagPunctuation "->")) --- (layoutTypeWithInfo denv env rty)))
+                        ((layoutTypesWithInfoAndPrec denv env 2 (wordL (tagPunctuation "*")) argtys --- wordL (tagPunctuation "->")) --- (layoutReturnType denv env rty)))
 
 
     /// Layout a unit expression 
@@ -995,6 +995,8 @@ module private PrintTypes =
     and private layoutTypesWithInfoAndPrec denv env prec sep typl = 
         sepListL sep (List.map (layoutTypeWithInfoAndPrec denv env prec) typl)
 
+    and private layoutReturnType denv env rty = layoutTypeWithInfoAndPrec denv env 4 rty
+
     /// Layout a single type, taking TypeSimplificationInfo into account 
     and private layoutTypeWithInfo denv env ty = 
         layoutTypeWithInfoAndPrec denv env 5 ty
@@ -1032,8 +1034,6 @@ module private PrintTypes =
             |> List.map (sepListL (wordL (tagPunctuation "*")))
         allArgsL
 
-    let layoutReturnType denv env rty = layoutTypeWithInfoAndPrec denv env 4 rty
-
     let layoutGenericParameterTypes denv env = 
       function
       | [] -> emptyL