Skip to content

Commit e130d25

Browse files
authored
fix vsix dependency version calculations (#6565)
1 parent 7fa61b7 commit e130d25

4 files changed

Lines changed: 11 additions & 5 deletions

File tree

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<Project>
2+
3+
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.targets', '$(MSBuildThisFileDirectory)../'))" />
4+
5+
<Target Name="GetVSGeneralVersion" Returns="$(VSGeneralVersion)">
6+
</Target>
7+
8+
</Project>

vsintegration/Vsix/VisualFSharpFull/Source.extension.vsixmanifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<MoreInfo>https://docs.microsoft.com/en-us/dotnet/articles/fsharp/</MoreInfo>
1010
</Metadata>
1111
<Installation Experimental="true">
12-
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[|%CurrentProject%;GetVSGeneralVersion|]" />
12+
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[|%CurrentProject%;GetVSGeneralVersion|,)" />
1313
</Installation>
1414
<Installer>
1515
<Actions>

vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,4 @@
263263
<PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonPackageVersion)" />
264264
</ItemGroup>
265265

266-
<Target Name="GetVSGeneralVersion" Returns="$(VSGeneralVersion)" />
267-
268266
</Project>

vsintegration/Vsix/VisualFSharpTemplates/Source.extension.vsixmanifest

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<MoreInfo>https://docs.microsoft.com/en-us/dotnet/articles/fsharp/</MoreInfo>
1111
</Metadata>
1212
<Installation Experimental="true">
13-
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[15.0]" />
13+
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[|%CurrentProject%;GetVSGeneralVersion|,)" />
1414
</Installation>
1515
<Dependencies>
1616
<Dependency Id="Microsoft.Framework.NDP" DisplayName="Microsoft .NET Framework" d:Source="Manual" Version="[4.6,)" />
@@ -21,7 +21,7 @@
2121
<Asset Type="Microsoft.VisualStudio.ProjectTemplate" d:Source="Project" Path="ProjectTemplates" d:TargetPath="|LibraryProject;TemplateProjectOutputGroup|" d:ProjectName="LibraryProject" d:VsixSubPath="ProjectTemplates" />
2222
</Assets>
2323
<Prerequisites>
24-
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[15.0,16.0)" DisplayName="Visual Studio core editor" />
24+
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[|%CurrentProject%;GetVSGeneralVersion|,)" DisplayName="Visual Studio core editor" />
2525
</Prerequisites>
2626

2727
</PackageManifest>

0 commit comments

Comments
 (0)