Always parenthesize dynamic SQL expressions.

This is intended to discourage (not prevent) wacky, unstable uses like adding
whole clauses/extra statements.

Author: rspeele

src/Rezoom.SQL.Compiler/DefaultExprTranslator.fs

@@ -244,16 +244,16 @@ type DefaultExprTranslator(statement : StatementTranslator, indexer : IParameter
             yield text ")"
         }
     override __.NeedsParens(expr) =
-        match expr with
+        match expr.Value with
         | LiteralExpr _
-        | BindParameterExpr _
         | ColumnNameExpr _ 
         | CastExpr _
         | FunctionInvocationExpr _
         | ScalarSubqueryExpr _ -> false
+        | BindParameterExpr _ when expr.Info.Type.Type <> RawSQLType -> false
         | _ -> true
     override this.Expr(expr, _) =
-        let needsParens = this.NeedsParens(expr.Value)
+        let needsParens = this.NeedsParens(expr)
         seq {
             if needsParens then yield text "("
             yield!

src/Rezoom.SQL.Compiler/Translators.fs

@@ -96,7 +96,7 @@ and [<AbstractClass>] ExprTranslator() =
     abstract member Case : case : TCaseExpr -> Fragments
     abstract member Exists : subquery : TSelectStmt -> Fragments
     abstract member ScalarSubquery : subquery : TSelectStmt -> Fragments
-    abstract member NeedsParens : TExprType -> bool
+    abstract member NeedsParens : TExpr -> bool
     abstract member Expr : expr : TExpr * context : ExprTranslationContext -> Fragments