Quick fix to prevent duplicate child event listeners on Java database module

chrisbianca · chrisbianca · commit 363c1b6ce29c · 2016-11-21T11:17:10.000Z
diff --git a/android/src/main/java/io/fullstack/firestack/FirestackDatabase.java b/android/src/main/java/io/fullstack/firestack/FirestackDatabase.java
@@ -10,6 +10,7 @@
 
 import com.facebook.react.bridge.Callback;
 import com.facebook.react.bridge.Arguments;
+import com.facebook.react.bridge.WritableArray;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.bridge.ReadableMap;
 import com.facebook.react.bridge.ReactMethod;
@@ -79,11 +80,9 @@ public void onCancelled(DatabaseError error) {
           self.handleDatabaseError(name, mPath, error);
         }
       };
+      Query ref = this.getDatabaseQueryAtPathAndModifiers(modifiersArray);
+      ref.addChildEventListener(mEventListener);
     }
-
-    Query ref = this.getDatabaseQueryAtPathAndModifiers(modifiersArray);
-    ref.addChildEventListener(mEventListener);
-    //this.setListeningTo(mPath, modifiersString, name);
   }
 
   public void addValueEventListener(final String name, final ReadableArray modifiersArray, final String modifiersString) {

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`
`11`	`11`	`import com.facebook.react.bridge.Callback;`
`12`	`12`	`import com.facebook.react.bridge.Arguments;`
	`13`	`+import com.facebook.react.bridge.WritableArray;`
`13`	`14`	`import com.facebook.react.bridge.WritableMap;`
`14`	`15`	`import com.facebook.react.bridge.ReadableMap;`
`15`	`16`	`import com.facebook.react.bridge.ReactMethod;`
`@@ -79,11 +80,9 @@ public void onCancelled(DatabaseError error) {`
`79`	`80`	`self.handleDatabaseError(name, mPath, error);`
`80`	`81`	`}`
`81`	`82`	`};`
	`83`	`+ Query ref = this.getDatabaseQueryAtPathAndModifiers(modifiersArray);`
	`84`	`+ ref.addChildEventListener(mEventListener);`
`82`	`85`	`}`
`83`		`-`
`84`		`- Query ref = this.getDatabaseQueryAtPathAndModifiers(modifiersArray);`
`85`		`- ref.addChildEventListener(mEventListener);`
`86`		`- //this.setListeningTo(mPath, modifiersString, name);`
`87`	`86`	`}`
`88`	`87`
`89`	`88`	`public void addValueEventListener(final String name, final ReadableArray modifiersArray, final String modifiersString) {`