lint

Author: scivision

scripts/activateMatlab.py

@@ -29,8 +29,9 @@
 def _registry_search(release: str) -> Path | None:
     try:
         # must use "\" as path separator in Windows registry
-        matlab_path = winreg.QueryValue(
-            winreg.HKEY_LOCAL_MACHINE, rf"SOFTWARE\MathWorks\{release}\MATLAB"
+        matlab_path = winreg.QueryValue(  # type: ignore[attr-defined]
+            winreg.HKEY_LOCAL_MACHINE,  # type: ignore[attr-defined]
+            rf"SOFTWARE\MathWorks\{release}\MATLAB",
         )
 
         return Path(matlab_path)

scripts/get_matlab_version_xml.py

@@ -28,14 +28,18 @@ def get_matlab_version(root: Path) -> str:
         raise FileNotFoundError(xmlPath)
 
     tree = ET.parse(xmlPath)
-    root = tree.getroot()
+    xroot = tree.getroot()
 
-    return root.find('version').text
+    v = xroot.find("version")
+
+    return v.text.strip() if v is not None and v.text is not None else "Unknown version"
 
 
 if __name__ == "__main__":
-    parser = argparse.ArgumentParser(description="Get MATLAB version from VersionInfo.xml")
-    parser.add_argument('matlab_root', nargs='?', help="Path to MATLAB root directory")
+    parser = argparse.ArgumentParser(
+        description="Get MATLAB version from VersionInfo.xml"
+    )
+    parser.add_argument("matlab_root", nargs="?", help="Path to MATLAB root directory")
     args = parser.parse_args()
 
     root = Path(args.matlab_root) if args.matlab_root else get_matlab_root()

scripts/test_matlab_versions.py

@@ -5,24 +5,24 @@
 
 # these are HPC system specific
 version_keys = [
-"2025b",
-"2025a",
-"2024b",
-"2024a",
-"2023b",
-"2023a",
-"2022b",
-"2022a",
-"2021b",
-"2021a",
-"2020b",
-"2020a",
-"2019b",
-"2019a",
-"2018b",
-"2018a",
-"2017b",
-"2017a",
+    "2025b",
+    "2025a",
+    "2024b",
+    "2024a",
+    "2023b",
+    "2023a",
+    "2022b",
+    "2022a",
+    "2021b",
+    "2021a",
+    "2020b",
+    "2020a",
+    "2019b",
+    "2019a",
+    "2018b",
+    "2018a",
+    "2017b",
+    "2017a",
 ]
 
 R = Path(__file__).parents[1]
@@ -32,7 +32,9 @@
 @pytest.mark.parametrize("version", version_keys)
 def test_matlab_version(version):
 
-    ret = subprocess.run(f"module is-avail matlab/{version}", shell=True, capture_output=True, text=True)
+    ret = subprocess.run(
+        f"module is-avail matlab/{version}", shell=True, capture_output=True, text=True
+    )
     if ret.returncode != 0:
         pytest.skip(f"MATLAB version {version} not available {ret.stderr}")