Force usage of jsonrpc_params

The whole `scrubbed_params` has seems a little fishy to me - it is
copying the JSON RPC params up into the main params hash. But it cannot
copy all of them because you could then invoke somebody else's chatop
command by providing a `chatop` argument to your own command.

It is better to separate concerns and just leave the JSON RPC params
where they are.

Author: TwP

lib/chatops/controller.rb

@@ -27,11 +27,6 @@ def list
     end
 
     def process(*args)
-      scrubbed_params = jsonrpc_params.except(
-        :user, :mention_slug, :method, :controller, :action, :params, :room_id)
-
-      scrubbed_params.each { |k, v| params[k] = v }
-
       if params[:chatop].present?
         params[:action] = params[:chatop]
         args[0] = params[:action]

spec/lib/chatops/controller_spec.rb

@@ -14,8 +14,8 @@
     chatop :wcid,
     /(?:where can i deploy|wcid)(?: (?<app>\S+))?/,
     "where can i deploy?" do
-      return jsonrpc_invalid_params("I need nope, sorry") if params[:app] == "nope"
-      jsonrpc_success "You can deploy #{params["app"]} just fine."
+      return jsonrpc_invalid_params("I need nope, sorry") if jsonrpc_params[:app] == "nope"
+      jsonrpc_success "You can deploy #{jsonrpc_params["app"]} just fine."
     end
 
     chatop :foobar,
@@ -35,7 +35,7 @@ def unexcluded_chatop_method
     end
 
     def ensure_app_given
-      return jsonrpc_invalid_params("I need an app, every time") unless params[:app].present?
+      return jsonrpc_invalid_params("I need an app, every time") unless jsonrpc_params[:app].present?
     end
   end