Skip to content

Commit ba351da

Browse files
dbussinkleequarella
authored andcommitted
Reduce the dependencies of the chatops controller
When looking at options to mitigate https://github.com/github/github/issues/174690, my initial approach there failed because we can't drop some Rails components because we use gems that express all of Rails as a dependency instead of the parts they need. The chatops controller is one of those. It looks like though it only needs ActiveSupport & ActionPack so I reduced the dependencies here to just those parts.
1 parent 9cb11b7 commit ba351da

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

chatops-controller.gemspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ Gem::Specification.new do |s|
1717
s.files = Dir["{app,config,db,lib}/**/*", "README.md"]
1818
s.test_files = Dir["spec/**/*"]
1919

20-
s.add_dependency "rails", ">= 6.0"
20+
s.add_dependency "actionpack", ">= 6.0"
21+
s.add_dependency "activesupport", ">= 6.0"
2122

2223
s.add_development_dependency "rspec-rails", "~> 3"
2324
s.add_development_dependency "pry", "~> 0"

0 commit comments

Comments
 (0)