pvfs-failure-context-update

This commit adds more context to the chatop tests failures by checking for keys in the json_response and raising if they do not exist. This should give users a better idea of why their expectations fail.

Author: panthervfs

lib/chatops/controller/test_case_helpers.rb

@@ -42,6 +42,7 @@ def chatop(method, params = {})
   def chat(message, user, room_id = "123", message_id = "456")
     get :list
     json_response = JSON.load(response.body)
+    raise "Invalid Chatop response - BODY: #{json_response}" unless json_response.key?("methods")
     matchers = json_response["methods"].map { |name, metadata|
       metadata = metadata.dup
       metadata["name"] = name
@@ -75,6 +76,7 @@ def chatop_response
 
   def chatop_error
     json_response = JSON.load(response.body)
+    raise "There is no chatop error - BODY: #{json_response}" unless json_response.key?("error")
     json_response["error"]["message"]
   end