Merge pull request #17 from github/fix-nil-error

Fix error when no alt public key present

Author: Ben Lavender

lib/chatops/controller.rb

@@ -102,7 +102,7 @@ def ensure_chatops_authenticated
       body = request.raw_post || ""
       signature_string = [@chatops_url, @chatops_nonce, @chatops_timestamp, body].join("\n")
       # We return this just to aid client debugging.
-      response.headers["Chatops-Signature-String"] = signature_string
+      response.headers["Chatops-Signature-String"] = Base64.strict_encode64(signature_string)
       raise ConfigurationError.new("You need to add a client's public key in .pem format via #{Chatops.public_key_env_var_name}") unless Chatops.public_key.present?
       if signature_valid?(Chatops.public_key, @chatops_signature, signature_string) ||
           signature_valid?(Chatops.alt_public_key, @chatops_signature, signature_string)
@@ -167,6 +167,7 @@ def should_authenticate_chatops?
     end
 
     def signature_valid?(key_string, signature, signature_string)
+      return false unless key_string.present?
       digest = OpenSSL::Digest::SHA256.new
       decoded_signature = Base64.decode64(signature)
       public_key = OpenSSL::PKey::RSA.new(key_string)

lib/chatops/controller/version.rb

@@ -1,3 +1,3 @@
 module ChatopsController
-  VERSION = "3.0.0"
+  VERSION = "3.0.1"
 end

spec/lib/chatops/controller_spec.rb

@@ -77,7 +77,7 @@ def rails_flexible_post(path, outer_params, jsonrpc_params = nil)
     signature = Base64.encode64(@private_key.sign(digest, signature_string))
     request.headers["Chatops-Signature"] = "Signature keyid=foo,signature=#{signature}"
     get :list
-    expect(response.headers["Chatops-Signature-String"]).to eq signature_string
+    expect(response.headers["Chatops-Signature-String"]).to eq Base64.strict_encode64(signature_string)
     expect(response.status).to eq 200
     expect(response).to be_valid_json
   end