A3-1-5: Downgrade to an "audit" query

This rule talks about developer intention in a way that is
not possible to determine fully automatically with any confidence.
We therefore downgrade this rule to an "audit" query.

Author: lcartey

cpp/autosar/src/rules/A3-1-5/NonTrivialNonTemplateFunctionDefinedInsideClassDefinition.ql

@@ -7,6 +7,7 @@
  * @precision very-high
  * @problem.severity recommendation
  * @tags external/autosar/id/a3-1-5
+ *       external/autosar/audit
  *       external/autosar/allocated-target/design
  *       external/autosar/enforcement/partially-automated
  *       external/autosar/obligation/required

rule_packages/cpp/Classes.json

@@ -185,7 +185,9 @@
           "precision": "very-high",
           "severity": "recommendation",
           "short_name": "NonTrivialNonTemplateFunctionDefinedInsideClassDefinition",
-          "tags": []
+          "tags": [
+            "external/autosar/audit"
+          ]
         }
       ],
       "title": "A function definition shall only be placed in a class definition if (1) the function is intended to be inlined (2) it is a member function template (3) it is a member function of a class template."