C#: Add some tests with incomplete type information.

Author: michaelnebel

csharp/ql/test/query-tests/Language Abuse/SimplifyBoolExpr/SimplifyBoolExpr.cs

@@ -44,5 +44,8 @@ void Fn()
         if (true != false) ;
         if (true && true) ;
         if (true || false) ;
+
+        bool? boption = false;
+        if (boption == true) ; // GOOD. Cant be simplified like a regular bool
     }
 }

csharp/ql/test/query-tests/standalone/Language Abuse/SimplifyBoolExpr/SimplifyBoolExpr.cs

@@ -58,3 +58,25 @@ class IncompleteNestedOperatorTest
         return lambda() || Local();
     }
 }
+
+class Test
+{
+    public class Container
+    {
+        public bool? Field;
+    }
+
+    public void Fn()
+    {
+        bool? boption = false;
+        if (boption == true) ; // GOOD. Can't be simplified like a regular bool
+
+        bool b = false;
+        if (b ? boption : false) ; // GOOD. Can't be simplified like a regular bool
+
+        // Emulating incomplete type information by not declaring container explicitly.
+        if (container.Field == true) ; // GOOD. Can't be simplified like a regular bool
+
+        if (b ? container.Field : false) ; // GOOD. Can't be simplified like a regular bool
+    }
+}

csharp/ql/test/query-tests/standalone/Language Abuse/SimplifyBoolExpr/SimplifyBoolExpr.expected

@@ -1,3 +1,9 @@
+#select
 | SimplifyBoolExpr.cs:10:29:10:56 | !... | The expression '!(A == B)' can be simplified to 'A != B'. |
 | SimplifyBoolExpr.cs:13:33:13:64 | !... | The expression '!(A == B)' can be simplified to 'A != B'. |
 | SimplifyBoolExpr.cs:45:115:45:130 | !... | The expression '!(A == B)' can be simplified to 'A != B'. |
+| SimplifyBoolExpr.cs:78:13:78:35 | ... == ... | The expression 'A == true' can be simplified to 'A'. |
+| SimplifyBoolExpr.cs:80:13:80:39 | ... ? ... : ... | The expression 'A ? B : false' can be simplified to 'A && B'. |
+testFailures
+| SimplifyBoolExpr.cs:78:13:78:35 | The expression 'A == true' can be simplified to 'A'. | Unexpected result: Alert |
+| SimplifyBoolExpr.cs:80:13:80:39 | The expression 'A ? B : false' can be simplified to 'A && B'. | Unexpected result: Alert |