Skip to content

[lint-monster] Fix error handling: fmt.Errorf, json.Marshal, strconv.Atoi, and os.Setenv issues #36173

@github-actions

Description

@github-actions

Summary

Fix 19 linting issues related to improper error handling and environment mutations.

Issues (19 total):

  • fmt.Errorf with no format verbs (2 in utc_offset.go)
  • strconv.Atoi errors discarded (4 in utc_offset.go)
  • json.Marshal errors discarded (10 in test files)
  • os.Setenv mutations (4 in CLI code)

Key Files

  • pkg/workflow/utc_offset.go
  • pkg/cli/engine_secrets.go
  • pkg/cli/add_interactive_orchestrator.go
  • Test files: logs_*.go, staged_filtering_test.go, add_comment_target_repo_test.go

Checklist

  • Use errors.New() instead of fmt.Errorf() where no format verbs
  • Handle strconv.Atoi() errors
  • Handle json.Marshal() errors (use require.NoError/assert.NoError)
  • Refactor os.Setenv() to pass config explicitly
  • Run make golint-custom to verify fixes
  • Run make test-unit to ensure no regressions

Expected outcome: All 19 issues resolved, zero broken tests.

Generated by 🧌 LintMonster · haiku45 134.2K ·

  • expires on Jun 8, 2026, 3:52 AM UTC

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions